View Issue Details

IDProjectCategoryView StatusLast Update
0000573Spring engineGeneralpublic2007-10-29 20:47
Reporteryuritch Assigned Totvo  
PrioritynormalSeverityfeatureReproducibilityN/A
Status resolvedResolutionfixed 
Summary0000573: [patch] Aircraft crashing control via COB set/get
DescriptionThis patch allows to control aircraft crashing state with COB set/get commands. A new set/get constant CRASHING=96 is introduced for this. Get CRASHING returnt wheter a unit is crashing or not, set CRASHING to 1 makes a unit start crashing, I'm not sure if set CRASHING to 0 will abort the crashing sequence or not. All of the above only makes sence for aircraft though.
Additional InformationI made that at work, so I cannot test it here. It's quite simple though.
TagsNo tags attached.
Attached Files
crashing.patch (Attachment missing)
crashing_4661.patch (Attachment missing)
Checked infolog.txt for Errors

Activities

tvo

2007-10-28 13:22

reporter   ~0001369

Any chance you could test it after all?

I'm not quite fond of committing untested changes to complex statemachines like the (Air)MoveTypes.

KDR_11k

2007-10-28 14:34

reporter   ~0001372

Making a plane crash can be done with Spring.DestroyUnit in Lua, too.

yuritch

2007-10-29 08:03

reporter   ~0001374

Last edited: 2007-10-29 08:07

Ok, I'll test it today. I forgot about this patch, else I'd have it tested long ago.
Lua is good, but COB is simpler most of the time.

yuritch

2007-10-29 19:32

reporter   ~0001375

Last edited: 2007-10-29 19:33

Ok, I tested the patch and had to update it (get/set ID 96 was already taken by STEALTH, now I'm using ID 97 for CRASHING). Now it works fully - get CRASHING returns if the aircraft is crashing or not, set CRASHING to 1 makes it start crashing, set CRASHING to 0 aborts crashing sequence (and makes it targettable by weapons again if the mod has FireAtCrashing=0). My tests confirmed that all of the above works, and existing aircraft crashing behaviours (that is, without using set CRASHING) seem to be unaffected.
The patch is made against svn revision 4661.

tvo

2007-10-29 20:47

reporter   ~0001376

Committed, thank you.

Note though that it won't for for CTAAirMoveType aircraft, but I forgot what the difference was (with CAirMoveType aircraft).

Issue History

Date Modified Username Field Change
2007-07-30 08:31 yuritch New Issue
2007-07-30 08:31 yuritch File Added: crashing.patch
2007-10-28 13:22 tvo Note Added: 0001369
2007-10-28 13:22 tvo Status new => feedback
2007-10-28 14:34 KDR_11k Note Added: 0001372
2007-10-29 08:03 yuritch Note Added: 0001374
2007-10-29 08:07 yuritch Note Edited: 0001374
2007-10-29 19:28 yuritch File Added: crashing_4661.patch
2007-10-29 19:32 yuritch Note Added: 0001375
2007-10-29 19:33 yuritch Note Edited: 0001375
2007-10-29 20:46 tvo Status feedback => assigned
2007-10-29 20:46 tvo Assigned To => tvo
2007-10-29 20:47 tvo Status assigned => resolved
2007-10-29 20:47 tvo Resolution open => fixed
2007-10-29 20:47 tvo Note Added: 0001376