| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0000057 | Spring engine | General | public | 2006-01-27 18:21 | 2006-02-01 18:54 | ||||
| Reporter | M2 | ||||||||
| Assigned To | jcnossen | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0000057: Various small things. | ||||||||
| Description | In UnitDefHandler.cpp on line 49 the number of units in the game are defined as ?óÔé¼?ônumUnits = tafiles.size()?óÔé¼?Ø but since disabled units isn?óÔé¼Ôäót loaded CUnitDefHandler?óÔé¼Ôäós destructor will delete yardmaps that doesn?óÔé¼Ôäót exist. You should probably add something like this after the call to tafiles.size(). if(gameSetup) numUnits -= gameSetup->restrictedUnits.size(); In lesson2.cpp ?óÔé¼?ôdelete gameSetup;?óÔé¼?Ø should be moved to after ?óÔé¼?ôdelete game;?óÔé¼?Ø because gameSetup is used in CUnit?óÔé¼Ôäós destructor witch gets called by ?óÔé¼?ôdelete game;?óÔé¼?Ø. (Nitpicking: it is ok to delete null pointers in C++) tdf_grammar.hpp line 63 I think you actually intended to write expect_brace. Btw you generate a nice error message how about presenting it to users who use the release build to write mods. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
jcnossen (reporter) 2006-01-27 18:57 |
Thanks a lot, If you want I can get you a berlios account to help more with Spring, it will be much appreciated... They are very few non-porting programmers atm, and LOTS of things to do. Reply to jelmerc@hotmail.com if you're interested. PS: I can't commit these fixes atm, because my working copy of that particular code contains a lot debug output writing. They will be committed when I can remove the debug stuff. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-01-27 18:21 | M2 | New Issue | |
| 2006-01-27 18:21 | M2 | Status | new => assigned |
| 2006-01-27 18:21 | M2 | Assigned To | => jcnossen |
| 2006-01-27 18:57 | jcnossen | Note Added: 0000057 | |
| 2006-01-27 18:57 | jcnossen | Status | assigned => acknowledged |
| 2006-02-01 18:54 | jcnossen | Status | acknowledged => resolved |
| 2006-02-01 18:54 | jcnossen | Resolution | open => fixed |
| Issue History |