| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005671 | Spring engine | Lua | public | 2017-07-23 04:08 | 2017-07-24 17:50 | ||||
| Reporter | sprung | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | low | Severity | feature | Reproducibility | have not tried | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 103.0 +git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0005671: Add offscreen parameter in `IsAbove` callin (similar to 0005311) | ||||||||
| Description | The "x/y reported as middle of the screen when offscreen" from 0005311 also exists in the `IsAbove` callin. This is a request to add a similar third parameter there as well. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for lua Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2017-07-23 17:25 |
A simpler solution (and less work) would be to just not call IsAbove when the mouse is offscreen. |
|
silentwings (reporter) 2017-07-24 05:24 |
An even simpler solution might be to not have a "fake" mouse in the middle of the screen when the mouse is actually off-screen ;) |
|
Kloot (developer) 2017-07-24 10:10 |
that is done for reasons: https://github.com/spring/spring/blob/develop/rts/System/Input/MouseInput.cpp#L82 |
|
Kloot (developer) 2017-07-24 17:50 |
Fix bc9bb4d37eef08eac8c2801a7c27e7093c09e9b0 committed to develop branch: fix 0005671, repo: spring changeset id: 8543 |
| Notes |
| Related Changesets |
|||
|
spring: develop bc9bb4d3
Timestamp: 2017-07-24 17:55:37 Author: Kloot [ Details ] [ Diff ] |
fix 0005671 | ||
| mod - doc/changelog.txt | [ Diff ] [ File ] | ||
| mod - rts/Game/UI/GuiHandler.cpp | [ Diff ] [ File ] | ||
| mod - rts/Game/UI/InputReceiver.cpp | [ Diff ] [ File ] | ||
| mod - rts/Game/UI/MouseHandler.cpp | [ Diff ] [ File ] | ||
| mod - rts/Game/UnsyncedGameCommands.cpp | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-07-23 04:08 | sprung | New Issue | |
| 2017-07-23 17:25 | Kloot | Note Added: 0018113 | |
| 2017-07-24 05:24 | silentwings | Note Added: 0018118 | |
| 2017-07-24 10:10 | Kloot | Note Added: 0018121 | |
| 2017-07-24 17:50 | Kloot | Changeset attached | => spring develop bc9bb4d3 |
| 2017-07-24 17:50 | Kloot | Note Added: 0018122 | |
| 2017-07-24 17:50 | Kloot | Assigned To | => Kloot |
| 2017-07-24 17:50 | Kloot | Status | new => resolved |
| 2017-07-24 17:50 | Kloot | Resolution | open => fixed |
| Issue History |