0000056: Add event in demofile.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000056

Spring engine

General

public

2006-01-23 20:53

2007-08-27 15:21

Reporter

flanipuche

Assigned To

tvo

Priority

normal

Severity

feature

Reproducibility

N/A

Status

closed

Resolution

won't fix

Product Version

Target Version

Fixed in Version

Summary

0000056: Add event in demofile.

Description

During the recording of the file demo, to add an event when a player dies. NETMSG_PLAYERDIES (40) for example? Currently, only the death of a team produces this event type (NETMSG_SENDPLAYERSTAT). I would need some for my project.

Additional Information

Into GameServer.cpp, we have:

void CGameServer::CheckForGameEnd(void)
{
...
if(numActive<=1){
  gameEndDetected=true;
  gameEndTime=0;
  outbuf[0]=NETMSG_SENDPLAYERSTAT;
  serverNet->SendData(outbuf,1);
    }
..

That would be fine if we had this: (into Team.cpp)

void CTeam::RemoveUnit(CUnit* unit,RemoveType type)
{
...
if(units.empty()){
  info->AddLine("Team%i(%s) is no more",teamNum,gs->players
  outbuf[0]=NETMSG_PLAYERDIES; // new
  outbuf[1]= teamNum; // new
  serverNet->SendData(outbuf,2); // new
...

Tags

No tags attached.

Checked infolog.txt for Errors

Attached Files

Relationships

Relationships

Notes
~0000230 jcnossen (reporter) 2006-06-12 23:41 Last edited: 2006-07-03 12:50	patches are welcome:)

~0001165 tvo (reporter) 2007-08-27 15:21	Soon we will have metadata in replays anyway, e.g. the allyteam that won the game and the player & team statistics. Given that this includes activeUnits and the entire statHistory is saved, you can then figure out when a team died. Note that there is no such thing as a player dying, since a player is just a client and controls a team. There can be multiple players controlling a team (shared comms) or no player controlling a team (if it is controlled by GlobalAI).

Notes

Date Modified	Username	Field	Change
Issue History
2006-01-23 20:53	flanipuche	New Issue
2006-01-23 20:53	flanipuche	Status	new => assigned
2006-01-23 20:53	flanipuche	Assigned To	=> jcnossen
2006-06-12 23:41	jcnossen	Note Added: 0000230
2006-06-12 23:41	jcnossen	Status	assigned => feedback
2006-07-03 12:50	jcnossen	Note Edited: 0000230
2007-08-27 15:18	tvo	Status	feedback => assigned
2007-08-27 15:18	tvo	Assigned To	jcnossen => tvo
2007-08-27 15:21	tvo	Status	assigned => closed
2007-08-27 15:21	tvo	Note Added: 0001165
2007-08-27 15:21	tvo	Resolution	open => won't fix

Issue History