View Issue Details

IDProjectCategoryView StatusLast Update
0005433Spring engineGeneralpublic2017-02-10 12:43
ReporterGoogle_Frog Assigned Tohokomoko  
PrioritynormalSeverityminorReproducibilitysometimes
Status resolvedResolutionfixed 
Product Version103.0 +git 
Summary0005433: 103.0.1-516-g0ffb9de - Frozen image with win64 build
DescriptionWin64 Spring fails to draw un-minimized maximized windows.
 * Get the 64 bit windows build of Spring.
 * Start Chobby in windowed mode.
 * Maximize the window (make it take up the whole screen).
 * Minimize the window (send it to taskbar).
 * Un-minimize the window.
The resulting window now looks something like the attached screenshot.

I can reliably reproduce the issue many subsequent times. Sometimes the issue does not occur. I have made it occur with luaMenu by itself and luaMenu with a game loaded.
TagsNo tags attached.
Attached Files
frozenImage.jpg (Attachment missing)
Checked infolog.txt for Errors

Activities

Google_Frog

2017-01-21 12:19

reporter   ~0017092

Unmaximimizing the window while the image is frozen causes the window to work correctly.

Google_Frog

2017-01-21 12:34

reporter   ~0017093

103.0.1-298-gaf1edb1 has the bug.

103.0.1-261-gc7b69e6 has the bug.

103.0.1-247-gf2f84f3 has the bug.

103.0.1-240-g0640fdb has the bug.

103.0.1-235-g7edddd2 works.

103.0.1-172-g403ce5f works.

103.0.1-134-g819e5b4 works.

I'm fairly sure the source is this: https://github.com/spring/spring/commit/93f07f2e65f00270c375b39a8b7c1275d17e9fc9

Disabling the widget that uses AllowDraw has no effect.

Google_Frog

2017-01-21 12:38

reporter   ~0017095

The commit message implies that the redraw is forced every 30 seconds. If I leave the maximized window alone for 30 seconds then it draws a new frame correctly. However, it continues to draw at one frame per 30 seconds until un-maximized.

Google_Frog

2017-01-21 12:45

reporter   ~0017096

I put Spring.Echo("AllowDraw occurs", os.date("!%M"), os.date("!%S")) in widget:AllowDraw() and similar for widget:Update() and found that AllowDraw is not called during the frozen image period.
infolog.txt (Attachment missing)

Kloot

2017-01-21 12:58

developer   ~0017099

it's conditional on the window being visible which would point to an SDL bug.

hokomoko

2017-01-23 22:52

developer   ~0017124

I've updated SDL2 in mingwlibs64, please check if it persists in b68830c

Google_Frog

2017-01-24 01:50

reporter   ~0017131

Seems fixed in 103.0.1-529-gb68830c. I'll get Licho to test the version of the bug that he experienced but that I could never reproduce (black window after screens go to sleep).

hokomoko

2017-02-10 12:43

developer   ~0017263

no further feedback -> assumed fixed

Issue History

Date Modified Username Field Change
2017-01-21 12:16 Google_Frog New Issue
2017-01-21 12:16 Google_Frog File Added: frozenImage.jpg
2017-01-21 12:19 Google_Frog Note Added: 0017092
2017-01-21 12:34 Google_Frog Note Added: 0017093
2017-01-21 12:38 Google_Frog Note Added: 0017095
2017-01-21 12:45 Google_Frog File Added: infolog.txt
2017-01-21 12:45 Google_Frog Note Added: 0017096
2017-01-21 12:58 Kloot Note Added: 0017099
2017-01-23 22:52 hokomoko Note Added: 0017124
2017-01-24 01:50 Google_Frog Note Added: 0017131
2017-01-25 21:42 hokomoko Assigned To => hokomoko
2017-01-25 21:42 hokomoko Status new => feedback
2017-02-10 12:43 hokomoko Status feedback => resolved
2017-02-10 12:43 hokomoko Resolution open => fixed
2017-02-10 12:43 hokomoko Note Added: 0017263