View Issue Details

IDProjectCategoryView StatusLast Update
0005352Spring engineGeneralpublic2016-10-01 22:19
ReporterLicho Assigned Toabma  
PrioritynormalSeverityfeatureReproducibilityalways
Status closedResolutionno change required 
Product Version103.0 +git 
Summary0005352: Rapid references inside modinfo.lua don't work for games downloaded with other tools
DescriptionThe rapid reference in modinfo (eg. rapid://zk:stable) relies on "rapid" folder existing with repos.gz in corresponding folder.

External tools however download only packages and pool folder, as specified by rapid.

Therefore if for example Zero-K lobby downloads zk:stable, there is no "rapid" folder, just correct "pool" and "packages" and you can start a game with reference to internal name of Zero-K.

The engine however fails to locate the same resource by rapid tag zk:stable and says that it cannot find it.
Steps To Reproduce1) Get a game mutator, for example this ZK mission
http://zero-k.info/Missions/File/140

2) modify its modinfo.lua to reference rapid://zk:stable if needed

3) download zk stable using pr-downloader zk:stable

4) rename "rapid" folder

5) start the mutator. It will work with reference to internal name of Zero-K but fail with reference to zk:stable






TagsNo tags attached.
Checked infolog.txt for Errors

Activities

abma

2016-09-25 12:14

administrator   ~0016686

> The engine however fails to locate the same resource by rapid tag zk:stable and says that it cannot find it.

yes, because the rapid folder is missing. how should the engine find the correct name of the game without the files in the rapid folder? thats the only reference where a mapping from zk:stable to the real name is.

> External tools however download only packages and pool folder, as specified by rapid.

pr-downloader is based on https://github.com/tvo/rapid which was one of the most complete implementations and it created this folder, too.

IMO this is a missing feature in zk's implementation of rapid. For making tags work you need to keep the folder structure / download the rapid folder.


-> i think this is a feature request: spring should try to download the rapid files itself when it can't find the requested tag.



how should it work offline without keeping the rapid folder?


Issue History

Date Modified Username Field Change
2016-09-24 13:52 Licho New Issue
2016-09-25 12:14 abma Note Added: 0016686
2016-09-25 12:14 abma Priority high => normal
2016-09-25 12:14 abma Severity major => feature
2016-09-25 12:26 abma Status new => feedback
2016-10-01 22:19 abma Status feedback => closed
2016-10-01 22:19 abma Assigned To => abma
2016-10-01 22:19 abma Resolution open => no change required