View Issue Details

IDProjectCategoryView StatusLast Update
0005335Spring engineGeneralpublic2016-08-25 03:46
Reporterabma Assigned Toabma  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version103.0 
Target Version104.0 
Summary0005335: desync in Spring.GetUnitCommands()
Descriptionhttps://github.com/spring/spring/blob/cd9aae5bae6fb295eae775d9cb19dd5f5a514249/rts/Lua/LuaSyncedRead.cpp#L4015

spring_gettime() is NOT sync safe!

has to be removed from that function... either gameframe or calls must be used there!
Additional Informationhttps://springrts.com/phpbb/viewtopic.php?f=11&p=579024
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

abma

2016-08-25 03:39

administrator   ~0016617

as alternative just log to infolog.txt and don't make it a lua error!

abma

2016-08-25 03:46

administrator   ~0016618

Fix a15a6acb4bfbfa4d2287afeec7946a257271bd2e committed to develop branch: fix 0005335: desync in Spring.GetUnitCommands() with bogous lua code, repo: spring changeset id: 7263

Issue History

Date Modified Username Field Change
2016-08-25 03:27 abma New Issue
2016-08-25 03:39 abma Note Added: 0016617
2016-08-25 03:46 abma Changeset attached => spring develop a15a6acb
2016-08-25 03:46 abma Note Added: 0016618
2016-08-25 03:46 abma Assigned To => abma
2016-08-25 03:46 abma Status new => resolved
2016-08-25 03:46 abma Resolution open => fixed