| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005335 | Spring engine | General | public | 2016-08-25 03:27 | 2016-08-25 03:46 | ||||
| Reporter | abma | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 103.0 | ||||||||
| Target Version | 104.0 | Fixed in Version | |||||||
| Summary | 0005335: desync in Spring.GetUnitCommands() | ||||||||
| Description | https://github.com/spring/spring/blob/cd9aae5bae6fb295eae775d9cb19dd5f5a514249/rts/Lua/LuaSyncedRead.cpp#L4015 spring_gettime() is NOT sync safe! has to be removed from that function... either gameframe or calls must be used there! | ||||||||
| Additional Information | https://springrts.com/phpbb/viewtopic.php?f=11&p=579024 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for lua Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2016-08-25 03:39 |
as alternative just log to infolog.txt and don't make it a lua error! |
|
abma (administrator) 2016-08-25 03:46 |
Fix a15a6acb4bfbfa4d2287afeec7946a257271bd2e committed to develop branch: fix 0005335: desync in Spring.GetUnitCommands() with bogous lua code, repo: spring changeset id: 7263 |
| Notes |
| Related Changesets |
|||
|
spring: develop a15a6acb
Timestamp: 2016-08-25 03:47:32 Author: abma [ Details ] [ Diff ] |
fix 0005335: desync in Spring.GetUnitCommands() with bogous lua code | ||
| mod - rts/Lua/LuaSyncedRead.cpp | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-08-25 03:27 | abma | New Issue | |
| 2016-08-25 03:39 | abma | Note Added: 0016617 | |
| 2016-08-25 03:46 | abma | Changeset attached | => spring develop a15a6acb |
| 2016-08-25 03:46 | abma | Note Added: 0016618 | |
| 2016-08-25 03:46 | abma | Assigned To | => abma |
| 2016-08-25 03:46 | abma | Status | new => resolved |
| 2016-08-25 03:46 | abma | Resolution | open => fixed |
| Issue History |