View Issue Details

IDProjectCategoryView StatusLast Update
0005267Spring engineGeneralpublic2016-06-06 16:01
ReporterGoogle_Frog Assigned Tohokomoko  
PriorityhighSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version101.0+git 
Summary0005267: UnLOS+Identified structures lack radar dots.
DescriptionUnits in radar coverage are supposed to draw with a radar dot, regardless of your zoom level. Identified structures do not draw a radar dot when zoomed in.

This is bad because the missing radar dot implies that the structure was scouted and subsequently killed (while not on radar) or jammed. It also breaks consistency and makes radar harder to read as the missing dot looks like a gap.
TagsNo tags attached.
Attached Files
screen00257.jpg (Attachment missing)
Checked infolog.txt for Errors

Activities

Google_Frog

2016-06-06 11:33

reporter   ~0016403

This worked in 100.0, structures had radar dots. However, looking at the code I don't know why it worked in 100.0. The code around that time suggests that this was never meant to be a feature.

The fix will be in this function: https://github.com/spring/spring/blob/develop/rts/Rendering/UnitDrawer.cpp#L1433

I have trouble compiling though and want to do so before making a PR.

hokomoko

2016-06-06 16:01

developer   ~0016405

Fix 7b39a62fc296d63aedd4cce0d04fd31c4eed7ed7 committed to develop branch: Fix 0005267 0005268

Always draw icons for ghosted buildings (disregard zoom level).
Update INLOS and CONTRADAR for nanoframes., repo: spring changeset id: 7116

Issue History

Date Modified Username Field Change
2016-06-06 10:23 Google_Frog New Issue
2016-06-06 10:23 Google_Frog File Added: screen00257.jpg
2016-06-06 11:33 Google_Frog Note Added: 0016403
2016-06-06 12:07 hokomoko Assigned To => hokomoko
2016-06-06 12:07 hokomoko Status new => assigned
2016-06-06 16:01 hokomoko Changeset attached => spring develop 7b39a62f
2016-06-06 16:01 hokomoko Note Added: 0016405
2016-06-06 16:01 hokomoko Status assigned => resolved
2016-06-06 16:01 hokomoko Resolution open => fixed