View Issue Details

IDProjectCategoryView StatusLast Update
0005264Spring engineLuapublic2016-12-17 18:29
ReporterGoogle_Frog Assigned ToKloot  
PrioritylowSeverityminorReproducibilityalways
Status closedResolutionno change required 
Product Version101.0+git 
Summary0005264: 101.0.1-408 Movecontrol rotation is backwards
DescriptionAt some point the interpretation in move control rotation and rotation velocity reversed. This is demonstrated by this commit which solves the problem gameside: https://github.com/ZeroK-RTS/Zero-K/commit/a317351d73508f44644f7fbcf2532b8146f6b7f3
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

FLOZi

2016-06-08 19:05

reporter   ~0016412

Appears to be the case as far back as at least 101.0.1-136-g54d97ff, judging by MCL dropship behaviour being badly messed up. 101.0 is fine.

FLOZi

2016-07-04 01:02

reporter   ~0016464

GFs lua fix works for me also, but this is not an intended change, is it?

Kloot

2016-07-04 01:46

developer   ~0016465

https://github.com/spring/spring/blob/develop/doc/changelog.txt#L98

Google_Frog

2016-07-04 05:50

reporter   ~0016466

It looks like this is an intended change so the ticket can be closed.

FLOZi

2016-07-04 17:32

reporter   ~0016469

Last edited: 2016-07-04 17:45

Are we sure the right one was changed? Would imply all of our MoveCtrl code was logically borked to start with wouldn't it? (Not an impossibility, 'try it till it works' would likely result in that)Thought I would have noticed if everything was reversed from Upspring, but then again maybe it ought to be as Upspring is mirrored vs in game anyway. My brain hurts.


edit: nvm looked at 5155, kloot is infallible. Guess I need to go edit all my MC.SetRotation then, don't like the lua bandaid fix in the long term.

Issue History

Date Modified Username Field Change
2016-06-02 13:54 Google_Frog New Issue
2016-06-08 19:05 FLOZi Note Added: 0016412
2016-07-04 01:02 FLOZi Note Added: 0016464
2016-07-04 01:46 Kloot Note Added: 0016465
2016-07-04 05:50 Google_Frog Note Added: 0016466
2016-07-04 17:32 FLOZi Note Added: 0016469
2016-07-04 17:35 FLOZi Note Edited: 0016469
2016-07-04 17:45 FLOZi Note Edited: 0016469
2016-12-17 18:29 Kloot Assigned To => Kloot
2016-12-17 18:29 Kloot Status new => closed
2016-12-17 18:29 Kloot Resolution open => no change required