View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0005213Spring engineLuapublic2016-04-23 01:522016-04-23 06:50
ReporterPicassoCT Assigned Tocleanrock  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Summary0005213: gadgets.lua AllowBuilderHoldFire is broken
Description
Thrown Error is:
[f=0000546] Error: LuaRules::RunCallIn: error = 2, AllowBuilderHoldFire, [Internal Lua error: Call failure] [string "luagadgets/gadgets.lua"]:1161: bad argument #1 to 'ipairs' (table expected, got function)

https://github.com/spring/spring/blob/aaf05cb6ff1effbdfcc3628ad5f0e77f70781972/cont/base/springcontent/LuaGadgets/gadgets.lua#L1201
Steps To ReproduceStart any game using base content
Build a armed Builder
Additional InformationCorrect Version?
function gadgetHandler:AllowBuilderHoldFire(unitID, unitDefID, action)
  for _,g in r_ipairs(self.AllowBuilderHoldFireList) do
    if (not g:AllowBuilderHoldFire(unitID, unitDefID, action)) then
      return false
    end
  end
  return true
end

Could not find the used Lists in spring source.
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

cleanrock

2016-04-23 06:50

reporter   ~0016200

Fix f5c8308cba6014e9ce81c19833614eb484642205 committed to develop branch: correct AllowBuilderHoldFire, hopefully fixes 0005213

My mistake in 5108698., repo: spring changeset id: 6992

Issue History

Date Modified Username Field Change
2016-04-23 01:52 PicassoCT New Issue
2016-04-23 06:50 cleanrock Changeset attached => spring develop f5c8308c
2016-04-23 06:50 cleanrock Note Added: 0016200
2016-04-23 06:50 cleanrock Assigned To => cleanrock
2016-04-23 06:50 cleanrock Status new => resolved
2016-04-23 06:50 cleanrock Resolution open => fixed