View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005199 | Spring engine | General | public | 2016-04-05 18:54 | 2016-04-05 21:36 |
| Reporter | hokomoko | Assigned To | Kloot | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 101.0+git | ||||
| Target Version | 102.0 | ||||
| Summary | 0005199: Unit selection square invisible in dynamic water and bumpwater with refraction=2 | ||||
| Description | Similar drawings by widgets are invisible as well. bisected to: https://github.com/spring/spring/commit/c2680ebe6119699b1a98ca32ea66b3b146fd07e2 an example of widgets affected is UnitShapes in ZK used for selection circles | ||||
| Steps To Reproduce | Start BA in FinnsRevenge /water 2 /luaui disable /give armpw in water select armpw | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
What are the side effects of c2680ebe6119699b1a98ca32ea66b3b146fd07e2 being reverted? |
|
|
does "it would annoy me" count? the proper fix is a one-liner, but changes water 2's look (depending on the map). you can decide for yourself how much you consider that an issue as of 4479f7f8da. |
|
|
"does "it would annoy me" count?" it does, but I think you will agree that units having no selection rectangle in certain water types is a severe issue. I'd even prefer disabling said water types than releasing spring in the current state. BumpWaterRefraction = 2 will still have the issue after your commit btw. Is there a way for games to circumvent this and achieve acceptable functionality in the current state? |
|
|
BumpWaterRefraction=2 isn't the default value, and could be forced to 1 if need be. games can ensure selection shapes are always visible, they would just have to draw their own (like BAR does) with depthtesting disabled. |
|
|
I couldn't find anything bad in 4479f7f8da (maybe didn't test the right map) For now I think I'll force BumpWaterRefraction to <2 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-04-05 18:54 | hokomoko | New Issue | |
| 2016-04-05 18:56 | hokomoko | Steps to Reproduce Updated | |
| 2016-04-05 18:58 | hokomoko | Steps to Reproduce Updated | |
| 2016-04-05 19:33 | hokomoko | Description Updated | |
| 2016-04-05 19:44 | Kloot | Relationship added | duplicate of 0005162 |
| 2016-04-05 19:45 | Kloot | Status | new => closed |
| 2016-04-05 19:45 | Kloot | Resolution | open => duplicate |
| 2016-04-05 19:47 | hokomoko | Note Added: 0016158 | |
| 2016-04-05 19:47 | hokomoko | Status | closed => feedback |
| 2016-04-05 19:47 | hokomoko | Resolution | duplicate => reopened |
| 2016-04-05 20:13 | Kloot | Note Added: 0016159 | |
| 2016-04-05 20:14 | Kloot | Note Edited: 0016159 | |
| 2016-04-05 20:20 | hokomoko | Note Added: 0016160 | |
| 2016-04-05 20:20 | hokomoko | Status | feedback => new |
| 2016-04-05 20:35 | Kloot | Note Added: 0016161 | |
| 2016-04-05 21:11 | hokomoko | Note Added: 0016163 | |
| 2016-04-05 21:35 | hokomoko | Changeset attached | => spring develop e2e1a80f |
| 2016-04-05 21:36 | hokomoko | Status | new => closed |
| 2016-04-05 21:36 | hokomoko | Assigned To | => Kloot |
| 2016-04-05 21:36 | hokomoko | Resolution | reopened => fixed |
| 2016-04-05 21:36 | hokomoko | Changeset attached | => spring develop 4479f7f8 |
