View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0005197 | Spring engine | General | public | 2016-04-03 14:58 | 2017-07-17 19:28 | ||||
Reporter | Beherith | ||||||||
Assigned To | Kloot | ||||||||
Priority | low | Severity | tweak | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | 101.0+git | ||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0005197: Grass goes black with metal view | ||||||||
Description | As metal info texture does an additive blend onto the terrain, it doesnt change the appearance of metal free terrain. But the grass shader does read it, and blends it with the dark black of the metal free areas. https://github.com/spring/spring/blob/c381a5592de87ffdc1d98a4c110fe00a7e6f25f7/rts/Rendering/Env/GrassDrawer.cpp#L355 I would propose to check also check that it is not metaltex as well. (My foolishness tells me its its probably not that simple.) | ||||||||
Steps To Reproduce | Any game on DSD, hit f4; grass is nearly black. | ||||||||
Tags | No tags attached. | ||||||||
Checked infolog.txt for Errors | |||||||||
Attached Files |
|
![]() |
||||||
|
![]() |
|
Kloot (developer) 2017-07-17 19:28 |
Fix 37dc5346ca121d38ecb451e556ac1ac655f14ca4 committed to develop branch: fix 0005197, repo: spring changeset id: 8529 |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2016-04-03 14:58 | Beherith | New Issue | |
2016-04-03 15:12 | Kloot | Relationship added | related to 0005164 |
2017-07-17 19:28 | Kloot | Changeset attached | => spring develop 37dc5346 |
2017-07-17 19:28 | Kloot | Note Added: 0018060 | |
2017-07-17 19:28 | Kloot | Assigned To | => Kloot |
2017-07-17 19:28 | Kloot | Status | new => resolved |
2017-07-17 19:28 | Kloot | Resolution | open => fixed |