| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005160 | Spring engine | General | public | 2016-03-10 10:09 | 2016-03-10 12:01 | ||||
| Reporter | Beherith | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 101.0+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0005160: Spring.SetSunLighting does not have an effect if applied at gadget:initialize | ||||||||
| Description | Lately BA/BAR/ZK have added a simple gadget that looks for default specular parameters with local mapSpecR, mapSpecG, mapSpecB = gl.GetSun("specular"). If this is left as default (0.1,0.1,0.1) , it is cleared with Spring.SetSunLighting because it causes overbrightness of the old maps. This gadget activates itself correctly, and even changes the variable value (as a subsequent /luarules reload does not cause it to trigger), but the rendering still has the specular enabled. This can be confirmed with BAR by typing /exec Spring.SetSunLighting({groundSpecularColor = {0,0,0,0}}) Once the above command is issued, the rendering is now correct. | ||||||||
| Steps To Reproduce | Load up BAR:test on a non-ssmf map, e.g. DSD. Note the overbrightness of the map. In infolog, verify "Map Sun Handler: Clearing groundSpecularColor via SetSunLighting because map does not change it from default." Try /luaui reload, map sun handler wont trigger (ergo gl.GetSun("specular") already returns 0,0,0), yet the overbrightness is still there Manually executing /exec Spring.SetSunLighting({groundSpecularColor = {0,0,0,0}}) fixes the issue. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Anonymous (viewer) 2016-03-10 12:01 |
Fix 3088f1e814fd1ba25f6262987101a8519826d6e7 committed to develop branch: fix 0005160, repo: spring changeset id: 6813 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-03-10 10:09 | Beherith | New Issue | |
| 2016-03-10 11:46 | Kloot | Assigned To | => Kloot |
| 2016-03-10 11:46 | Kloot | Status | new => assigned |
| 2016-03-10 12:01 | Changeset attached | => spring develop 3088f1e8 | |
| 2016-03-10 12:01 | Anonymous | Note Added: 0016040 | |
| 2016-03-10 12:01 | Anonymous | Status | assigned => resolved |
| 2016-03-10 12:01 | Anonymous | Resolution | open => fixed |
| Issue History |