2019-12-14 22:11 CET

View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0005157Spring engineAIpublic2016-03-09 18:24
Reporterlamer 
Assigned To 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version101.0+git 
Target VersionFixed in Version 
Summary0005157: skirmishAiCallback_Unit_getPos, skirmishAiCallback_Unit_getVel is broken
DescriptionMentioned functions doesn't work with cheats anymore.
Additional InformationMalicious commit:
$ git log -L 4030,4035:rts/ExternalAI/SSkirmishAICallbackImpl.cpp
commit 10283ad041d2d0b61fbdea7572b6e8c07948092c
Author: rtri <none@none>
Date: Fri Jan 8 02:40:29 2016 +0100

    improve code style/readability/quality in a few parts of rts/ExternalAI/

diff --git a/rts/ExternalAI/SSkirmishAICallbackImpl.cpp b/rts/ExternalAI/SSkirmishAICallbackImpl.cpp
--- a/rts/ExternalAI/SSkirmishAICallbackImpl.cpp
+++ b/rts/ExternalAI/SSkirmishAICallbackImpl.cpp
@@ -3740,8 +3716,6 @@
 }
 
 EXPORT(void) skirmishAiCallback_Unit_getPos(int skirmishAIId, int unitId, float* return_posF3_out) {
- if (skirmishAiCallback_Cheats_isEnabled(skirmishAIId)) {
+ if (skirmishAiCallback_Cheats_isEnabled(skirmishAIId))
                skirmishAIId_cheatCallback[skirmishAIId]->GetUnitPos(unitId).copyInto(return_posF3_out);
- } else {
- skirmishAIId_callback[skirmishAIId]->GetUnitPos(unitId).copyInto(return_posF3_out);
- }
+


Stop hating braces. {}'s are good for dev's health!
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
+Relationships

-Notes

~0016030

Anonymous (viewer)

Fix 932c5889a99f8565657beeb2017795e96a4a42c1 committed to develop branch: fix 0005157, repo: spring changeset id: 6805
+Notes

+Related Changesets

-Issue History
Date Modified Username Field Change
2016-03-09 17:53 lamer New Issue
2016-03-09 18:24 Changeset attached => spring develop 932c5889
2016-03-09 18:24 Anonymous Note Added: 0016030
2016-03-09 18:24 Anonymous Status new => resolved
2016-03-09 18:24 Anonymous Resolution open => fixed
+Issue History