View Issue Details

IDProjectCategoryView StatusLast Update
0005138Spring engineGeneralpublic2018-09-16 15:14
ReporterFloris Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product Version101.0 
Summary0005138: cannot resign (being a standin)
Descriptionwas also the case in v100

"[f=0032264] Spectator [teh]Flow sent invalid team resign"

aperantly the host/engine still considers me a spectator
TagsNo tags attached.
Attached Files
20160306_003830_DeltaSiegeDry_101.sdfz (Attachment missing)
Checked infolog.txt for Errors

Activities

abma

2016-03-06 01:28

administrator   ~0015976

replay?

Floris

2016-03-06 01:30

reporter   ~0015977

added

abma

2016-03-06 02:44

administrator   ~0015978

seems .spectator in GameServer isn't updated when AssignPlayerToTeam is called:

https://github.com/spring/spring/blob/develop/rts/Lua/LuaSyncedCtrl.cpp#L702

https://github.com/spring/spring/blob/develop/rts/Net/GameServer.cpp#L1417

silentwings

2018-09-12 08:14

reporter   ~0019347

> seems .spectator in GameServer isn't updated when AssignPlayerToTeam is called:

I didn't know .spectator existed when I wrote AssignPlayerToTeam. (Unfortunately, I don't have a build system for spring.exe set up atm, so can't fix.)

sprung

2018-09-12 18:37

reporter   ~0019349

It seems not to update .team as well, see 0006039

silentwings

2018-09-16 15:14

reporter   ~0019352

The precise effect is to call https://github.com/spring/spring/blob/720832e7993aec6e78e66aebb9dbe60b024834c5/rts/Lua/LuaSyncedCtrl.cpp#L696

Issue History

Date Modified Username Field Change
2016-03-06 01:02 Floris New Issue
2016-03-06 01:28 abma Note Added: 0015976
2016-03-06 01:29 Floris File Added: 20160306_003830_DeltaSiegeDry_101.sdfz
2016-03-06 01:30 Floris Note Added: 0015977
2016-03-06 02:44 abma Note Added: 0015978
2018-09-12 08:14 silentwings Note Added: 0019347
2018-09-12 18:37 sprung Note Added: 0019349
2018-09-16 15:14 silentwings Note Added: 0019352