| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005082 | Spring engine | General | public | 2016-02-11 12:01 | 2016-02-11 13:17 | ||||
| Reporter | Beherith | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 100.0+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0005082: Disabling advunitshading results in units that do not recieve any lighting. | ||||||||
| Description | Toggling to off while ingame and/or disabling advunitshading results in S3O units not recieving any lighting. | ||||||||
| Steps To Reproduce | Go ingame, spawn an s3o (not 3do) disable advunitshading. Observe lack of lighting as per the screenshots. | ||||||||
| Additional Information | I was oddly unable to reproduce this bug on my laptop with integrated intel graphics (no advunitshading support at all), but it did occur on my PC with proper nVidia gfx. Both Silentwings and hokomoko were able to reproduce this. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
hokomoko (developer) 2016-02-11 12:09 |
bisected to https://github.com/spring/spring/commit/243de8e |
|
Kloot (developer) 2016-02-11 12:26 |
can reproduce, but only with LoadingMT=1 (is there any code doesn't break as a result of that feature...) |
|
hokomoko (developer) 2016-02-11 12:31 |
apparently there was a reason for this code to be in two places: https://github.com/spring/spring/commit/243de8e#diff-b9a5a6e28ddddfb4972de65b8ecf2fc9L177 https://github.com/spring/spring/commit/243de8e#diff-b9a5a6e28ddddfb4972de65b8ecf2fc9L197 |
|
Anonymous (viewer) 2016-02-11 13:17 |
Fix 7172dc934df4ef0066cf3a24e87ce77d2bb5d0fa committed to develop branch: fix 0005082 fix infotex being bound by FeatureDrawer for no reason (WTF--), repo: spring changeset id: 6606 |
| Notes |
| Related Changesets |
|||
|
spring: develop 7172dc93
Timestamp: 2016-02-11 13:20:15 Author: rtri [ Details ] [ Diff ] |
fix 0005082 fix infotex being bound by FeatureDrawer for no reason (WTF--) |
||
| mod - rts/Rendering/FeatureDrawer.cpp | [ Diff ] [ File ] | ||
| mod - rts/Rendering/UnitDrawerState.cpp | [ Diff ] [ File ] | ||
| mod - rts/Rendering/WorldDrawer.cpp | [ Diff ] [ File ] | ||
| mod - rts/System/SpringApp.cpp | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-02-11 12:01 | Beherith | New Issue | |
| 2016-02-11 12:01 | Beherith | File Added: screen00631.jpg | |
| 2016-02-11 12:02 | Beherith | File Added: screen00632.jpg | |
| 2016-02-11 12:09 | hokomoko | Note Added: 0015727 | |
| 2016-02-11 12:26 | Kloot | Note Added: 0015728 | |
| 2016-02-11 12:31 | hokomoko | Note Added: 0015729 | |
| 2016-02-11 12:48 | Kloot | Assigned To | => Kloot |
| 2016-02-11 12:48 | Kloot | Status | new => assigned |
| 2016-02-11 13:17 | Changeset attached | => spring develop 7172dc93 | |
| 2016-02-11 13:17 | Anonymous | Note Added: 0015730 | |
| 2016-02-11 13:17 | Anonymous | Status | assigned => resolved |
| 2016-02-11 13:17 | Anonymous | Resolution | open => fixed |
| Issue History |