| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005080 | Spring engine | General | public | 2016-02-10 18:14 | 2016-02-11 17:27 | ||||
| Reporter | Jools | ||||||||
| Assigned To | hokomoko | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 100.0+git | ||||||||
| Target Version | Fixed in Version | 100.0+git | |||||||
| Summary | 0005080: Activated/deactivated callin spam when non-fighter plane is guarding | ||||||||
| Description | When non-fighter planes are set to guard something, and when CMD.IDLEMODE is set to 'Land', there is a spam of Activated() and Deactivated() in unit script. This is true also in 100.0 and probably goes many years back. This is why builders flap their wings when guarding labs, and it's probably why nobody uses the activated script callins for anything else (than flapping wings). If CMD.IDLEMODE is set to 'Fly', then this does not happen. It does also not happen to fighter type planes. | ||||||||
| Steps To Reproduce | The spam looks like this (brawler is already guarding a radar when land/fly is toggled): [f=0005617] <Jools> land [f=0005661] Deactivated() called for unitID:, 26080, arm_brawler [f=0005662] StoppedMoving called for unitID:, 26080, arm_brawler [f=0005674] Activated() called for unitID:, 26080, arm_brawler [f=0005675] Deactivated() called for unitID:, 26080, arm_brawler [f=0005675] StoppedMoving called for unitID:, 26080, arm_brawler [f=0005689] Activated() called for unitID:, 26080, arm_brawler [f=0005690] Deactivated() called for unitID:, 26080, arm_brawler [f=0005690] StoppedMoving called for unitID:, 26080, arm_brawler [f=0005704] Activated() called for unitID:, 26080, arm_brawler [f=0005705] Deactivated() called for unitID:, 26080, arm_brawler [f=0005705] StoppedMoving called for unitID:, 26080, arm_brawler [f=0005712] StoppedMoving called for unitID:, 26080, arm_brawler [f=0005719] Activated() called for unitID:, 26080, arm_brawler [f=0005720] Deactivated() called for unitID:, 26080, arm_brawler [f=0005720] StoppedMoving called for unitID:, 26080, arm_brawler [f=0005720] StartMoving called for unitID:, 26080, arm_brawler [f=0005729] StoppedMoving called for unitID:, 26080, arm_brawler [f=0005734] Activated() called for unitID:, 26080, arm_brawler [f=0005735] Deactivated() called for unitID:, 26080, arm_brawler [f=0005735] StoppedMoving called for unitID:, 26080, arm_brawler [f=0005735] StartMoving called for unitID:, 26080, arm_brawler [f=0005744] StoppedMoving called for unitID:, 26080, arm_brawler [f=0005749] Activated() called for unitID:, 26080, arm_brawler [f=0005750] Deactivated() called for unitID:, 26080, arm_brawler [f=0005750] StoppedMoving called for unitID:, 26080, arm_brawler [f=0005750] StartMoving called for unitID:, 26080, arm_brawler [f=0005757] Activated() called for unitID:, 26080, arm_brawler [f=0005804] <Jools> fly | ||||||||
| Additional Information | Can provide working replay if needed. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2016-02-10 20:36 |
fixed by 5270d4eb (note that after eb5b2b66 Activate/Deactivate are only called at takeoff/after landing) |
|
hokomoko (developer) 2016-02-11 17:24 |
Fix e827fefb5e96ad99ff28b8458ce574add902200b committed to develop branch: Fix 0005080, repo: spring changeset id: 6608 |
|
hokomoko (developer) 2016-02-11 17:27 |
Reverted back the activate/deactivate changes. Now guard keeps the unit flying so spam (and silly bobbing on the ground) stops. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-02-10 18:14 | Jools | New Issue | |
| 2016-02-10 18:14 | Jools | File Added: infolog.txt | |
| 2016-02-10 20:36 | Kloot | Note Added: 0015724 | |
| 2016-02-10 20:36 | Kloot | Status | new => resolved |
| 2016-02-10 20:36 | Kloot | Fixed in Version | => 100.0+git |
| 2016-02-10 20:36 | Kloot | Resolution | open => fixed |
| 2016-02-10 20:36 | Kloot | Assigned To | => Kloot |
| 2016-02-11 17:24 | hokomoko | Changeset attached | => spring develop e827fefb |
| 2016-02-11 17:24 | hokomoko | Note Added: 0015732 | |
| 2016-02-11 17:27 | hokomoko | Assigned To | Kloot => hokomoko |
| 2016-02-11 17:27 | hokomoko | Note Added: 0015733 | |
| 2016-02-11 17:27 | hokomoko | Status | resolved => feedback |
| 2016-02-11 17:27 | hokomoko | Resolution | fixed => reopened |
| 2016-02-11 17:27 | hokomoko | Status | feedback => resolved |
| 2016-02-11 17:27 | hokomoko | Resolution | reopened => fixed |
| Issue History |