View Issue Details

IDProjectCategoryView StatusLast Update
0000508Spring engineGeneralpublic2007-04-04 22:06
Reportersemi Assigned Totvo  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0000508: [patch] Queueing buildings with varying buildfacings cancel each other when shouldn't and vice versa.
DescriptionFunction GetCancelQueued, which should check if two queued buildings would cancel each other, does not take into account that either of the two might have different than default buildfacing.

This bug is present in the latest public release 0.74b3 and also in svn trunk current revision 3511.

My patch fixes this bug.

Bug can be reproduced by queueing a radar tower and then flipping buildfacing once, then queueing a vehicle lab right next to the tower on left or right side. This will cancel both, instead of adding the lab to the queue like it should.

Also if you first queue a radar tower and then flip buildfacing once, then try to queue the lab on top or bottom of the tower so that it's border goes through the middle of the tower, it will be queued, even though the two buildings are overlapping each other.

More realistic situation is to first flip buildfacing once, then queue a fusion, then try to circle it with DT.
TagsNo tags attached.
Attached Files
GetCancelQueued_semi.diff (Attachment missing)
Checked infolog.txt for Errors

Activities

tvo

2007-04-04 22:06

reporter   ~0000861

Committed, r3542 (or 3541 I feel like I'm swapping the two patches now ...)

Issue History

Date Modified Username Field Change
2007-03-31 22:39 semi New Issue
2007-03-31 22:40 semi File Added: GetCancelQueued_semi.diff
2007-04-04 22:05 tvo Status new => assigned
2007-04-04 22:05 tvo Assigned To => tvo
2007-04-04 22:06 tvo Status assigned => resolved
2007-04-04 22:06 tvo Resolution open => fixed
2007-04-04 22:06 tvo Note Added: 0000861