2019-08-26 12:11 CEST

View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0005077Spring engineGeneralpublic2016-02-11 14:38
ReporterGoogle_Frog 
Assigned Tohokomoko 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version100.0+git 
Target VersionFixed in Version 
Summary0005077: Invisible units for some users
DescriptionThe players Sortale has a bug in which many units are invisible.

Pastebin: http://pastebin.com/iH1PcPdY
Screenshot: https://www.dropbox.com/s/n7hwat10z3qf3go/Zero-k_editor56.jpg?dl=0

Some unit types were visible. Apparently they include corrl and dynsupport1 (from the screenshot) as well as armwin. They said that cloaked units are visible.
TagsNo tags attached.
Checked infolog.txt for lua Errors
Attached Files

-Relationships
+Relationships

-Notes

~0015720

Kloot (developer)

Last edited: 2016-02-10 14:30

View 2 revisions

infolog is full of "[f=-000001] Custom Unit Shaders:, Validation failed! - Different sampler types for same sample texture unit in fragment shader." lines

ATI drivers are more strict about such GLSL spec violations, fix your shader code

~0015721

hokomoko (developer)

Last edited: 2016-02-10 15:13

View 2 revisions

I think it's actually since during validation the uniforms aren't set, I'm pushing a patch that might fix this.

There's a huge duplication in
https://github.com/spring/spring/blob/develop/rts/Rendering/Shaders/LuaShaderContainer.cpp#L148
and
https://github.com/spring/spring/blob/develop/rts/Lua/LuaShaders.cpp#L402

~0015722

hokomoko (developer)

GoogleFrog please check if the issue still exists in 100.0.1-1140-g9ebb848 when it's available.

~0015731

Kloot (developer)

Judging from the commit (good catch) I assume it doesn't, but otherwise my previous comment stands.
+Notes

+Related Changesets

-Issue History
Date Modified Username Field Change
2016-02-10 14:13 Google_Frog New Issue
2016-02-10 14:26 Kloot Note Added: 0015720
2016-02-10 14:30 Kloot Note Edited: 0015720 View Revisions
2016-02-10 15:09 hokomoko Note Added: 0015721
2016-02-10 15:13 hokomoko Note Edited: 0015721 View Revisions
2016-02-10 15:16 hokomoko Changeset attached => spring develop 9ebb8481
2016-02-10 15:17 hokomoko Note Added: 0015722
2016-02-10 15:17 hokomoko Assigned To => hokomoko
2016-02-10 15:17 hokomoko Status new => feedback
2016-02-11 14:38 Kloot Note Added: 0015731
2016-02-11 14:38 Kloot Status feedback => resolved
2016-02-11 14:38 Kloot Resolution open => fixed
+Issue History