View Issue Details

IDProjectCategoryView StatusLast Update
0005050Spring engineGeneralpublic2018-05-03 12:43
Reporterabma Assigned Toabma  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version100.0 
Summary0005050: a lot of static vars are used in unitsync
Descriptionthis makes lobbies crash when compiled with different compiler / incompatible stdc++:


see
https://springrts.com/phpbb/viewtopic.php?f=12&t=34364&p=575529#p575529
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

abma

2016-02-04 16:29

administrator   ~0015617

seems it doesn't crash with the removal of Boost.Filesystem. I need feedback if this workarround works for others, too.

So, time for a RC!

If this works, this Problem is no release blocker.

Kloot

2016-02-04 20:38

developer   ~0015619

Last edited: 2016-02-04 20:40

The only other dev who has an affected lobby client and reads this mantis is cleanrock, no?

(can't test myself, don't have a gcc5-springlobby build)

abma

2016-02-07 22:21

administrator   ~0015651

dlmopen() seems to fix this. still it would be nice this wouldn't be necessary.

-> feature request

abma

2016-02-14 17:04

administrator   ~0015774

Last edited: 2016-02-14 17:05

most evil code:

https://github.com/spring/spring/blob/develop/rts/System/FileSystem/DataDirLocater.cpp#L37

DataDirLocater dataDirLocater;


https://github.com/spring/spring/blob/develop/rts/System/FileSystem/DataDirLocater.h#L181

this is initialized when the lib is loaded :-|

abma

2016-03-05 16:29

administrator   ~0015975

part #1 of ? https://github.com/spring/spring/commit/8e87cc16ebf2be1d6ae655b5db8ffbd31d8882ad

abma

2016-04-29 00:17

administrator   ~0016233

needs feedback if my changes already fixed it.

-> waiting for 102.0 release

abma

2018-05-03 12:43

administrator   ~0019064

seems to be fixed / didn't see a stacktrace which indicates such an error for a very long time

Issue History

Date Modified Username Field Change
2016-01-30 01:31 abma New Issue
2016-01-30 01:31 abma Status new => assigned
2016-01-30 01:31 abma Assigned To => abma
2016-02-04 16:29 abma Note Added: 0015617
2016-02-04 16:29 abma Status assigned => feedback
2016-02-04 20:38 Kloot Note Added: 0015619
2016-02-04 20:40 Kloot Note Edited: 0015619
2016-02-07 22:21 abma Note Added: 0015651
2016-02-07 22:21 abma Status feedback => assigned
2016-02-07 22:21 abma Severity major => feature
2016-02-07 22:21 abma Status assigned => new
2016-02-07 22:21 abma Target Version 101.0 =>
2016-02-07 23:25 abma Assigned To abma =>
2016-02-14 17:04 abma Note Added: 0015774
2016-02-14 17:05 abma Note Edited: 0015774
2016-03-05 16:29 abma Note Added: 0015975
2016-03-05 17:09 abma Target Version => 102.0
2016-04-29 00:17 abma Note Added: 0016233
2016-04-29 00:17 abma Assigned To => abma
2016-04-29 00:17 abma Status new => feedback
2016-04-29 00:17 abma Target Version 102.0 =>
2018-05-03 12:43 abma Status feedback => resolved
2018-05-03 12:43 abma Resolution open => fixed
2018-05-03 12:43 abma Note Added: 0019064