| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005040 | Spring engine | Lua | public | 2016-01-18 13:44 | 2016-01-18 19:49 | ||||
| Reporter | Klon | ||||||||
| Assigned To | hokomoko | ||||||||
| Priority | normal | Severity | feature | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 100.0 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0005040: Spring.LoadSoundDef has restrictive vfs modes | ||||||||
| Description | from reading through the code i gather that it only looks for files in SPRING_VFS_MOD & SPRING_VFS_ZIP, which excludes the possibilty to, for example, read from the spring/maps folder, if you arent running from a map. this restriction seems unnecessary. why not give it acess to the whole vfs? | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for lua Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Klon (reporter) 2016-01-18 13:55 Last edited: 2016-01-18 14:13 |
the editor widget i am working on creates map specific sounditem tables, that are meant to be distributed with the maps. for this, it would be highly useful if i could store and read back these tables in in the spring/maps folder. currently this is only possible if the map being edited is present as .sdd and run as such. ideally, the user would be able to create a sound setup for a map without having to unpack it first. |
|
Klon (reporter) 2016-01-18 17:09 Last edited: 2016-01-18 17:10 |
for clarification: reading sounditems from a path&file like this: "maps/Calayo123.sdd/LuaUI/Configs/ambient_sounds_templates.lua" will produce an error, if the game is not currently running this exact map from this exact folder. as far as i know this is because the VFS_ZIP / MOD access mode ignores anything that is not part of the current mod/map archive. https://github.com/spring/spring/blob/9bec15418279f1ecd87a5586d5f4ae44f8fee0ad/rts/System/Sound/OpenAL/Sound.cpp#L495 presumably, changing VFS_ZIP to VFS_ZIP_FIRST would cause it to look into the raw after failing to find it in the current archive. |
| Notes |
| Related Changesets |
|||
|
spring: develop bd4e14d3
Timestamp: 2016-01-18 19:23:21 Author: hokomoko [ Details ] [ Diff ] |
Allow LoadSoundDef to read from SPRING_VFS_RAW as well | ||
| mod - rts/Game/Game.cpp | [ Diff ] [ File ] | ||
| mod - rts/Lua/LuaUnsyncedCtrl.cpp | [ Diff ] [ File ] | ||
| mod - rts/System/Sound/ISound.cpp | [ Diff ] [ File ] | ||
| mod - rts/System/Sound/ISound.h | [ Diff ] [ File ] | ||
| mod - rts/System/Sound/Null/NullSound.h | [ Diff ] [ File ] | ||
| mod - rts/System/Sound/OpenAL/Sound.cpp | [ Diff ] [ File ] | ||
| mod - rts/System/Sound/OpenAL/Sound.h | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-01-18 13:44 | Klon | New Issue | |
| 2016-01-18 13:55 | Klon | Note Added: 0015539 | |
| 2016-01-18 13:56 | Klon | Note Edited: 0015539 | View Revisions |
| 2016-01-18 14:05 | Klon | Note Edited: 0015539 | View Revisions |
| 2016-01-18 14:07 | Klon | Note Edited: 0015539 | View Revisions |
| 2016-01-18 14:10 | Klon | Note Edited: 0015539 | View Revisions |
| 2016-01-18 14:13 | Klon | Note Edited: 0015539 | View Revisions |
| 2016-01-18 17:09 | Klon | Note Added: 0015542 | |
| 2016-01-18 17:10 | Klon | Note Edited: 0015542 | View Revisions |
| 2016-01-18 18:56 | hokomoko | Assigned To | => hokomoko |
| 2016-01-18 18:56 | hokomoko | Status | new => assigned |
| 2016-01-18 19:49 | hokomoko | Changeset attached | => spring develop bd4e14d3 |
| 2016-01-18 19:49 | hokomoko | Status | assigned => resolved |
| 2016-01-18 19:49 | hokomoko | Resolution | open => fixed |
| Issue History |