View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005033 | Spring engine | Linux | public | 2016-01-13 12:44 | 2016-01-26 11:11 |
| Reporter | MajorBoredom | Assigned To | jK | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 100.0+git | ||||
| Summary | 0005033: Dedicated / headless builds still need glu.h | ||||
| Description | Compile error below explains it. | ||||
| Steps To Reproduce | I put the following packages onto a fresh vm: ... boost boost-devel cmake libunwind libunwind-devel zlib zlib-devel p7zip make ninja-build DevIL-ILU openal No GL or SDL since it is headless. Then build the engine-dedicated target. | ||||
| Additional Information | FAILED: /usr/bin/c++ -DBOOST_NO_FENV_H -DDEDICATED -DHEADLESS -DNOT_USING_CREG -DNO_SOUND -DSPRING_DATADIR=\"/usr/local/share/games/spring\" -DSYNCCHECK -DUSE_LIBSQUISH -D_GLIBCXX_USE_NANOSLEEP -D_RANDOM_TCC -Irts/lib/lua/include -Iinclude/AL -Irts/lib -Irts -Isrc-generated/engine -Iinclude/SDL2 -Irts/lib/7zip -fuse-ld=gold -std=gnu++11 -fdiagnostics-color=always -mtune=generic -msse -mfpmath=sse -mno-sse2 -mno-sse3 -mno-ssse3 -mno-sse4.1 -mno-sse4.2 -mno-sse4 -mno-sse4a -mno-avx -mno-fma -mno-fma4 -mno-xop -mno-lwp -mno-avx2 -fsingle-precision-constant -frounding-math -mieee-fp -pipe -fno-strict-aliasing -fvisibility=hidden -fvisibility-inlines-hidden -pthread -O2 -Wno-unknown-pragmas -DNDEBUG -g -fpic -MMD -MT rts/builds/dedicated/CMakeFiles/engine-dedicated.dir/__/__/Lua/LuaParser.cpp.o -MF rts/builds/dedicated/CMakeFiles/engine-dedicated.dir/__/__/Lua/LuaParser.cpp.o.d -o rts/builds/dedicated/CMakeFiles/engine-dedicated.dir/__/__/Lua/LuaParser.cpp.o -c rts/Lua/LuaParser.cpp In file included from rts/Rendering/GL/myGL.h:13:0, from rts/Lua/LuaShaders.h:11, from rts/Lua/LuaContextData.h:6, from rts/Lua/LuaHandle.h:9, from rts/Lua/LuaUtils.h:13, from rts/Lua/LuaParser.cpp:17: rts/lib/headlessStubs/glewstub.h:13:21: fatal error: GL/glu.h: No such file or directory | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
IMHO the include dir in the spring source code should be removed: 1. the headers are platform dependant 2. it adds a lot of useless code in cmake 3. static builds exist: why to compile it? 4. the "cost" for installing glu/opengl/... required headers are pretty low |
|
|
Fix 9366c7785cbf786828b21e15c6b6800b6ceda71f committed to develop branch: fix 0005033: headlessStubs should always use included GL/* headers, repo: spring changeset id: 6393 |
|
|
Fix 8fda1bc1143b9a5bc7998d0a7b1f5fc3e23aa366 committed to develop branch: Revert "fix 0005033: headlessStubs should always use included GL/* headers" This reverts commit 9366c7785cbf786828b21e15c6b6800b6ceda71f., repo: spring changeset id: 6406 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-01-13 12:44 | MajorBoredom | New Issue | |
| 2016-01-13 14:33 | abma | Note Added: 0015503 | |
| 2016-01-13 14:33 | abma | Relationship added | related to 0004208 |
| 2016-01-13 14:33 | abma | Relationship added | related to 0004733 |
| 2016-01-26 10:52 | jK | Changeset attached | => spring develop 9366c778 |
| 2016-01-26 10:52 | jK | Note Added: 0015559 | |
| 2016-01-26 10:52 | jK | Assigned To | => jK |
| 2016-01-26 10:52 | jK | Status | new => resolved |
| 2016-01-26 10:52 | jK | Resolution | open => fixed |
| 2016-01-26 11:11 | jK | Changeset attached | => spring develop 8fda1bc1 |
| 2016-01-26 11:11 | jK | Note Added: 0015560 |
