|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0005015||Spring engine||General||public||2015-12-21 07:09||2015-12-22 22:38|
|Target Version||100.0+git||Fixed in Version|
|Summary||0005015: Outline shader doesn't seem to be working|
|Description||Outline shader (https://github.com/SpringCabal/Flove/blob/master/LuaUI/Widgets/gfx_outline.lua) seems not to be working correctly in the latest version.|
This is how it looks like: http://i.imgur.com/pnfSMKt.jpg (the trees don't have an outline).
There's also an additional white glowing tree in the background.
|Tags||No tags attached.|
|Checked infolog.txt for lua Errors|
|still works for me (tested with BA, XTA)|
I can confirm it mostly works correct with BA (by just copying the file I provided).
However, this is what happens when rockos shoot: http://i.imgur.com/QmyB7Mv.jpg . It also happens if the commander (or probably any other unit) is firing.
Regarding Flove, things may be different because Flove uses .dae instead .3do? Or inverted axis in its models (whatever that is)?
Last edited: 2015-12-22 19:33
No, it's just that blending is no longer default-enabled in DrawWorldPreUnit where the outline shader operates. I didn't make this change on purpose, but do think it is for the better.
The widget can be easily fixed with the attached diff.
|Lua doesn't have gl.Enable/gl.Disable, but rather gl.Blending. I've attached a diff version that works for me in BA (using "alpha" mode).|
OK I've figured out the issue with Flove...
It seems that the there's something wrong with the unit shaders (materials) in the way they interact with outline shaders.
Disabling the unit shaders here (https://github.com/SpringCabal/Flove/tree/master/ModelMaterials) causes the outline to work again.
I should point out that the unit shaders themselves work fine: the trees are swinging and the units change color when damaged. So there's something wrong when used in combination.
|Fix 2f755a285e81e6986c04fde74ddb7687ad3b57bf committed to develop branch: fix 0005015, repo: spring changeset id: 6021|
spring: develop 2f755a28
Timestamp: 2015-12-22 22:40:50
|mod - rts/Lua/LuaOpenGL.cpp|
|mod - rts/Rendering/FeatureDrawer.cpp|
|mod - rts/Rendering/FeatureDrawer.h|
|mod - rts/Rendering/GlobalRendering.h|
|mod - rts/Rendering/UnitDrawer.cpp|
|mod - rts/Rendering/UnitDrawer.h|
|2015-12-21 07:09||gajop||New Issue|
|2015-12-21 11:14||Kloot||Note Added: 0015389|
|2015-12-22 18:29||gajop||Note Added: 0015395|
|2015-12-22 19:19||Kloot||Note Added: 0015396|
|2015-12-22 19:19||Kloot||File Added: gfx_outline.diff|
|2015-12-22 19:33||Kloot||Note Edited: 0015396||View Revisions|
|2015-12-22 19:40||gajop||File Deleted: gfx_outline.diff|
|2015-12-22 19:40||gajop||File Added: gfx_outline.diff|
|2015-12-22 19:40||gajop||Note Added: 0015397|
|2015-12-22 19:41||gajop||File Deleted: gfx_outline.diff|
|2015-12-22 19:41||gajop||File Added: gfx_outline.diff|
|2015-12-22 19:45||gajop||Note Added: 0015398|
|2015-12-22 22:38||Changeset attached||=> spring develop 2f755a28|
|2015-12-22 22:38||Anonymous||Note Added: 0015399|
|2015-12-22 22:38||Anonymous||Status||new => resolved|
|2015-12-22 22:38||Anonymous||Resolution||open => fixed|