2019-12-07 07:41 CET

View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0004997Spring engineGeneralpublic2015-11-17 02:45
ReporterBeherith 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version100.0+git 
Target VersionFixed in Version 
Summary0004997: ModelFragProg.glsl truncates the normals when placing them into the normals buffer (1 liner fix)
Descriptionhttps://github.com/spring/spring/blob/develop/cont/base/springcontent/shaders/GLSL/ModelFragProg.glsl#L108

Should instead be:

gl_FragData[GBUFFER_NORMTEX_IDX] = vec4(normal*0.5+0.5, 1.0);

Because the normal buffer is RGBA and this truncates negative normals to 0.

I would open a pull request if i could add a separate one, but my git knowledge is insufficient for this.
Additional InformationThanks!
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
+Relationships

-Notes

~0015335

Anonymous (viewer)

Fix 323ab5a44293ee92ca70b12b6fdde0b0527ebe34 committed to develop branch: fix 0004997; close 0000224 and 0000225, repo: spring changeset id: 5777
+Notes

+Related Changesets

-Issue History
Date Modified Username Field Change
2015-11-14 14:59 Beherith New Issue
2015-11-17 02:44 Changeset attached => spring develop 323ab5a4
2015-11-17 02:44 Anonymous Note Added: 0015335
2015-11-17 02:45 Anonymous Status new => resolved
2015-11-17 02:45 Anonymous Resolution open => fixed
+Issue History