View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0004997 | Spring engine | General | public | 2015-11-14 14:59 | 2015-11-17 02:45 | ||||
Reporter | Beherith | ||||||||
Assigned To | |||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | 100.0+git | ||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0004997: ModelFragProg.glsl truncates the normals when placing them into the normals buffer (1 liner fix) | ||||||||
Description | https://github.com/spring/spring/blob/develop/cont/base/springcontent/shaders/GLSL/ModelFragProg.glsl#L108 Should instead be: gl_FragData[GBUFFER_NORMTEX_IDX] = vec4(normal*0.5+0.5, 1.0); Because the normal buffer is RGBA and this truncates negative normals to 0. I would open a pull request if i could add a separate one, but my git knowledge is insufficient for this. | ||||||||
Additional Information | Thanks! | ||||||||
Tags | No tags attached. | ||||||||
Checked infolog.txt for Errors | |||||||||
Attached Files |
|
![]() |
|
Anonymous (viewer) 2015-11-17 02:44 |
Fix 323ab5a44293ee92ca70b12b6fdde0b0527ebe34 committed to develop branch: fix 0004997; close 0000224 and 0000225, repo: spring changeset id: 5777 |