2019-12-12 12:06 CET

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0004939Spring engineGeneralpublic2019-01-18 20:12
Reporterabma 
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionwon't fix 
Product Version100.0+git 
Target VersionFixed in Version 
Summary0004939: used data types in demo file are bad int vs int32_t
Descriptionsizeof(int) may vary depending on compiler:
https://github.com/spring/spring/blob/develop/rts/System/LoadSave/demofile.h#L56

int should be replaced by int32_t imo
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
+Relationships

-Notes

~0015098

jK (developer)

http://www.viva64.com/media/images/content/a/examples_of_64-bit_errors/image45.png

~0015099

abma (administrator)

i know, its more a theoretical "problem":

http://en.cppreference.com/w/cpp/language/types
"at least 16", so it could be 32 bit, too

vs fixed width:

http://en.cppreference.com/w/cpp/types/integer

~0015100

hokomoko (developer)

When sending information over the network it's indeed recommended to use stdint types.

Am I going to go through the entire source and change that? no.

~0016835

dansan (reporter)

There might be a case where it is a problem: When saving the winningAllyTeams in demofiles. Those autohosts create bad demofiles:

* OverKillHost1 OS: Win2012 - Windows NT 6.3 - Build 9600
* EvoRTSDedicated6 OS: Win2012 - Windows NT 6.3 - Build 9600
* notAhost01NA OS: Win2012 - Windows NT 6.3 - Build 9600

See forum thread: https://springrts.com/phpbb/viewtopic.php?f=71&t=35698

Is this commit related to this issue: https://github.com/spring/spring/commit/da07d8db67269bf74fb68856431c1a18e7d66600 ?
+Notes

-Issue History
Date Modified Username Field Change
2015-08-27 03:22 abma New Issue
2015-08-27 03:22 abma Product Version => 100.0+git
2015-08-27 03:22 abma Description Updated View Revisions
2015-08-27 05:35 jK Note Added: 0015098
2015-08-27 13:41 abma Note Added: 0015099
2015-08-27 15:42 hokomoko Note Added: 0015100
2016-11-02 00:05 dansan Note Added: 0016835
2019-01-18 20:12 Kloot Status new => closed
2019-01-18 20:12 Kloot Resolution open => won't fix
+Issue History