View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004842Spring engineGeneralpublic2015-06-26 16:142015-06-26 20:22
Reporterhokomoko Assigned Tohokomoko  
PrioritynormalSeveritycrashReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version99.0+git 
Summary0004842: Crash related to new FeatureDrawer changes
Descriptionhttps://github.com/spring/spring/commit/7f91e0577d8c5633b7ecab44421b2ebbfddb7539#commitcomment-11876665

cleanrock:
I got a crash when testing 3ddffd4:
rts/Rendering/FeatureDrawer.cpp:254 CFeatureDrawer::DrawFeatureNow(CFeature const*, float)
rts/Rendering/FeatureDrawer.cpp:243 CFeatureDrawer::DrawOpaqueFeatures(int)
rts/Rendering/FeatureDrawer.cpp:399 CFeatureDrawer::DrawShadowPass()

My guess is IWorldObjectModelRenderer::AddFeature adds duplicate features.
I don't have a debug build atm to test the assert there because of 0004840.
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

hokomoko

2015-06-26 20:22

developer   ~0014712

Fix 78e4fe58383ade098a669e9a8e0c4cb8870cda55 committed to develop branch: Fix 0004842
FeatureHandler could delete a feature several times, and FeatureDestroyed was called for each.
a deleteMe member was added to features., repo: spring changeset id: 5254

Issue History

Date Modified Username Field Change
2015-06-26 16:14 hokomoko New Issue
2015-06-26 16:14 hokomoko Status new => assigned
2015-06-26 16:14 hokomoko Assigned To => hokomoko
2015-06-26 16:31 abma Description Updated
2015-06-26 20:22 hokomoko Changeset attached => spring develop 78e4fe58
2015-06-26 20:22 hokomoko Note Added: 0014712
2015-06-26 20:22 hokomoko Status assigned => resolved
2015-06-26 20:22 hokomoko Resolution open => fixed