2025-07-22 17:26 CEST

View Revisions: Issue #4842

Summary 0004842: Crash related to new FeatureDrawer changes
Revision 2015-06-26 16:31 by abma
Description https://github.com/spring/spring/commit/7f91e0577d8c5633b7ecab44421b2ebbfddb7539#commitcomment-11876665

cleanrock:
I got a crash when testing 3ddffd4:
rts/Rendering/FeatureDrawer.cpp:254 CFeatureDrawer::DrawFeatureNow(CFeature const*, float)
rts/Rendering/FeatureDrawer.cpp:243 CFeatureDrawer::DrawOpaqueFeatures(int)
rts/Rendering/FeatureDrawer.cpp:399 CFeatureDrawer::DrawShadowPass()

My guess is IWorldObjectModelRenderer::AddFeature adds duplicate features.
I don't have a debug build atm to test the assert there because of 0004840.
Revision 2015-06-26 16:14 by hokomoko
Description https://github.com/spring/spring/commit/7f91e0577d8c5633b7ecab44421b2ebbfddb7539#commitcomment-11876665

cleanrock:
I got a crash when testing 3ddffd4:
rts/Rendering/FeatureDrawer.cpp:254 CFeatureDrawer::DrawFeatureNow(CFeature const*, float)
rts/Rendering/FeatureDrawer.cpp:243 CFeatureDrawer::DrawOpaqueFeatures(int)
rts/Rendering/FeatureDrawer.cpp:399 CFeatureDrawer::DrawShadowPass()

My guess is IWorldObjectModelRenderer::AddFeature adds duplicate features.
I don't have a debug build atm to test the assert there because of 92857b5 .