View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004820 | Spring engine | General | public | 2015-06-19 02:28 | 2015-06-19 11:59 |
| Reporter | hokomoko | Assigned To | hokomoko | ||
| Priority | high | Severity | crash | Reproducibility | random |
| Status | resolved | Resolution | reopened | ||
| Product Version | 98.0.1+git | ||||
| Target Version | 99.0 | ||||
| Summary | 0004820: crash on 98.0.1-835-g5812f46 | ||||
| Description | If you run the game for long enough it sometimes crashes, probably due to some of my recent changes. | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
The assert is triggered: spring: /rts/Rendering/Models/WorldObjectModelRenderer.cpp:106: virtual void IWorldObjectModelRenderer::DelUnit(const CUnit*): Assertion `std::find(us.begin(), us.end(), const_cast<CUnit*>(u)) != us.end()' failed. Do Add/DelUnit and Add/DelProjectile really need these asserts? How about instead tracing a warning when std::find return the unexpected ? |
|
|
I see that before commit 7329648 the code handled these unexpected cases gracefully. |
|
|
Fix b543cf32af839a1c318a38a9c11a7d5d3b13b5f4 committed to develop branch: fix 0004820, repo: spring changeset id: 5167 |
|
|
Do you have a trace of when it is triggered? And yes, it is necessary, at least for projectiles which are added and removed very often (no need to go through the entire vector every time you add an element) |
|
|
Fix ef876630844b7458d20d0e9576199d95e70473aa committed to develop branch: Fix 0004820 Take 2, repo: spring changeset id: 5169 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-06-19 02:28 | hokomoko | New Issue | |
| 2015-06-19 02:28 | hokomoko | File Added: infolog.txt | |
| 2015-06-19 02:29 | hokomoko | File Added: script.txt | |
| 2015-06-19 09:51 | cleanrock | Note Added: 0014635 | |
| 2015-06-19 09:52 | cleanrock | Note Edited: 0014635 | |
| 2015-06-19 10:13 | cleanrock | Note Added: 0014636 | |
| 2015-06-19 10:32 | cleanrock | Changeset attached | => spring develop b543cf32 |
| 2015-06-19 10:32 | cleanrock | Note Added: 0014637 | |
| 2015-06-19 10:32 | cleanrock | Assigned To | => cleanrock |
| 2015-06-19 10:32 | cleanrock | Status | new => resolved |
| 2015-06-19 10:32 | cleanrock | Resolution | open => fixed |
| 2015-06-19 10:54 | hokomoko | Assigned To | cleanrock => hokomoko |
| 2015-06-19 10:54 | hokomoko | Note Added: 0014638 | |
| 2015-06-19 10:54 | hokomoko | Status | resolved => feedback |
| 2015-06-19 10:54 | hokomoko | Resolution | fixed => reopened |
| 2015-06-19 11:59 | hokomoko | Changeset attached | => spring develop 2cf629cf |
| 2015-06-19 11:59 | hokomoko | Changeset attached | => spring develop ef876630 |
| 2015-06-19 11:59 | hokomoko | Note Added: 0014639 | |
| 2015-06-19 11:59 | hokomoko | Status | feedback => assigned |
| 2015-06-19 11:59 | hokomoko | Status | assigned => resolved |
