| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004784 | Spring engine | General | public | 2015-05-17 19:36 | 2015-05-31 18:41 | ||||
| Reporter | jamerlan | ||||||||
| Assigned To | abma | ||||||||
| Priority | low | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 98.0 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004784: Improve unitsync error messages n case of duplicated files | ||||||||
| Description | When you have duplicates of maps(for example) - you receive error message from "unitsync" which is not clear. | ||||||||
| Steps To Reproduce | 1) Start springlobby from console 2) take a look at messages in console You can see messages like that: Error: Found a "tempest.sd7" already in "/home/revenant/.spring/maps/", ignoring one in "/home/revenant/.spring/maps/" | ||||||||
| Additional Information | I suggest to show all paths for that file. For example: Error: Found multiple copies of this file "tempest.sd7": 1) "/home/revenant/.spring/maps/tempest.sd7" 2) "/home/revenant/.spring/games/tempest.sd7", ignoring this one 3) "/home/revenant/games/spring98/maps/tempest.sd7", ignoring this one | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2015-05-29 11:15 |
relevant code: https://github.com/spring/spring/blob/develop/rts/System/FileSystem/ArchiveScanner.cpp#L569 |
|
jamerlan (reporter) 2015-05-29 23:28 |
Thanks Abma, I will try to fix/research this bug myself |
|
jamerlan (reporter) 2015-05-30 00:20 |
In my case the problem was in different case of the file name. So previously error message was not helpful because both files were located in the same directory. I changed error message to that: Error: Found a "/home/revenant/.spring/maps/tempest.sd7" already in "/home/revenant/.spring/maps/Tempest.sd7", ignoring second one Error: Found a "/home/revenant/.spring/maps/deltasiegedry.sd7" already in "/home/revenant/.spring/maps/DeltaSiegeDry.sd7", ignoring second one will attach a pull request soon |
|
jamerlan (reporter) 2015-05-30 00:39 |
https://github.com/spring/spring/pull/199 |
|
abma (administrator) 2015-05-31 18:41 |
Fix 3e9357518e20a86d58cc6062ea2d864d9ccb72f7 committed to develop branch: Merge pull request 0000199 from jamerlan/develop fix 0004784 Improve unitsync error messages n case of duplicated files, repo: spring changeset id: 5002 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-05-17 19:36 | jamerlan | New Issue | |
| 2015-05-29 11:15 | abma | Note Added: 0014495 | |
| 2015-05-29 23:28 | jamerlan | Note Added: 0014496 | |
| 2015-05-30 00:20 | jamerlan | Note Added: 0014498 | |
| 2015-05-30 00:39 | jamerlan | Note Added: 0014499 | |
| 2015-05-31 18:41 | jamerlan | Changeset attached | => spring develop b3076eb2 |
| 2015-05-31 18:41 | abma | Changeset attached | => spring develop 3e935751 |
| 2015-05-31 18:41 | abma | Note Added: 0014501 | |
| 2015-05-31 18:41 | abma | Assigned To | => abma |
| 2015-05-31 18:41 | abma | Status | new => resolved |
| 2015-05-31 18:41 | abma | Resolution | open => fixed |
| Issue History |