| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004763 | Spring engine | General | public | 2015-05-02 08:30 | 2015-06-18 01:06 | ||||
| Reporter | silentwings | ||||||||
| Assigned To | jK | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | closed | Resolution | no change required | ||||||
| Product Version | 98.0.1+git | ||||||||
| Target Version | 99.0 | Fixed in Version | |||||||
| Summary | 0004763: "Neither AimFromWeapon nor QueryWeapon defined or returned invalid pieceids" | ||||||||
| Description | Many BA units return an error such as "[f=0000000] Warning: corsent: weapon1: Neither AimFromWeapon nor QueryWeapon defined or returned invalid pieceids" The units with this error work absolutely fine, as far as I can tell. One of the scripts is attached. | ||||||||
| Steps To Reproduce | Give all with BA 8.17 and Spring 98.0.1-599. The warning does not appear in 98.0 and I didn't spot anything related to it in the changelog. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2015-05-03 01:01 |
i guess the warning is shown because the script doesn't has the function AimFromWeapon nor QueryWeapon which seems to be a must for some reason, idk. it works doesn't mean that it is correct. for details jk has to respond, i only try to "translate" :) |
|
abma (administrator) 2015-05-03 01:03 |
when reading this: https://springrts.com/wiki/Animation-LuaCallins#Weapons it really seems to be a must |
|
abma (administrator) 2015-05-03 01:11 Last edited: 2015-05-03 01:22 |
also site note: A LOT of units seems to not automaticly fire any more. |
|
silentwings (reporter) 2015-05-03 09:54 Last edited: 2015-05-03 10:05 |
> A LOT of units seems to not automaticly fire any more. More than the ones affected by this issue, or just those? I tested corsent and it did fire automatically. I have never written/edited a unit script, but a quick look at the code suggest that what has been broken is: units that have a weapon (sometimes more than one) but just not a primary weapon (e.g. in the script there is QueryWeapon2/QuerySecondary and AimFromWeapon2/AimFromScondary but not QueryWeapon/AimFromWeapon). |
|
abma (administrator) 2015-05-03 12:49 |
see demo. i've tested anti-air. |
|
abma (administrator) 2015-05-03 13:00 Last edited: 2015-05-03 13:01 |
@jk: how to fix this warning / how to fix aiming/shooting? a note in changelog would be nice as this is/was a breaking change... |
|
jK (developer) 2015-05-03 23:54 |
Fix b8fa60e1fed05da2aee504ab08bb4399bc3bb5e2 committed to develop branch: fix 0004763: incorrect warning for NoWeapons, repo: spring changeset id: 4891 |
|
silentwings (reporter) 2015-06-17 15:49 |
These warnings are still present, for the same units, in 98.0.1-785. |
|
jK (developer) 2015-06-17 16:10 |
for those the warning is correct and you have to fix the script |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-05-02 08:30 | silentwings | New Issue | |
| 2015-05-02 08:30 | silentwings | File Added: infolog.txt | |
| 2015-05-02 08:31 | silentwings | File Added: corsent.bos | |
| 2015-05-02 09:56 | abma | Target Version | => 99.0 |
| 2015-05-03 01:01 | abma | Note Added: 0014416 | |
| 2015-05-03 01:03 | abma | Note Added: 0014417 | |
| 2015-05-03 01:11 | abma | Note Added: 0014418 | |
| 2015-05-03 01:21 | abma | Severity | minor => major |
| 2015-05-03 01:22 | abma | Note Edited: 0014418 | View Revisions |
| 2015-05-03 09:54 | silentwings | Note Added: 0014419 | |
| 2015-05-03 10:05 | silentwings | Note Edited: 0014419 | View Revisions |
| 2015-05-03 12:49 | abma | File Added: 20150503_124257_DeltaSiegeDry_98.0.1-604-g19c4df4 develop.sdf | |
| 2015-05-03 12:49 | abma | Note Added: 0014420 | |
| 2015-05-03 12:59 | abma | Assigned To | => jK |
| 2015-05-03 12:59 | abma | Status | new => assigned |
| 2015-05-03 13:00 | abma | Note Added: 0014421 | |
| 2015-05-03 13:00 | abma | Note Edited: 0014421 | View Revisions |
| 2015-05-03 13:02 | abma | Note Edited: 0014421 | View Revisions |
| 2015-05-03 23:54 | jK | Changeset attached | => spring develop b8fa60e1 |
| 2015-05-03 23:54 | jK | Note Added: 0014427 | |
| 2015-05-03 23:54 | jK | Status | assigned => resolved |
| 2015-05-03 23:54 | jK | Resolution | open => fixed |
| 2015-06-17 15:49 | silentwings | Note Added: 0014621 | |
| 2015-06-17 15:49 | silentwings | Status | resolved => feedback |
| 2015-06-17 15:49 | silentwings | Resolution | fixed => reopened |
| 2015-06-17 16:10 | jK | Note Added: 0014622 | |
| 2015-06-18 01:06 | abma | Status | feedback => closed |
| 2015-06-18 01:06 | abma | Resolution | reopened => no change required |
| Issue History |