View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004735 | Spring engine | General | public | 2015-04-08 23:32 | 2015-04-09 09:34 |
| Reporter | UnitedMarsupials | Assigned To | abma | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 98.0 | ||||
| Summary | 0004735: Possible error in rts/System/Platform/CpuID.cpp | ||||
| Description | clang++ warns in this code and it does not look correct. Analysis at http://www.viva64.com/en/b/0293/ calls for correction too. Please, take a look at this patch -- logical && with a constant makes no sense, but bitwise & might... --- rts/System/Platform/CpuID.cpp 2014-10-07 16:09:51.000000000 -0400 +++ rts/System/Platform/CpuID.cpp 2015-04-07 20:23:18.000000000 -0400 @@ -142,5 +142,5 @@ ExecCPUID(&eax, &ebx, &ecx, &edx); - if ((ebx && 0xFFFF) == 0) + if ((ebx & 0xFFFF) == 0) return; | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
This is already fixed since 98.0: https://github.com/spring/spring/blob/develop/rts/System/Platform/CpuID.cpp#L144 |
|
|
There are many other similar warnings during build -- clang is very good at finding such things. Should I upload the complete build log? |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-04-08 23:32 | UnitedMarsupials | New Issue | |
| 2015-04-09 06:39 | cleanrock | Note Added: 0014311 | |
| 2015-04-09 06:50 | UnitedMarsupials | Note Added: 0014312 | |
| 2015-04-09 09:34 | abma | Status | new => closed |
| 2015-04-09 09:34 | abma | Assigned To | => abma |
| 2015-04-09 09:34 | abma | Resolution | open => no change required |
