| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004734 | Spring engine | General | public | 2015-04-08 22:46 | 2015-04-09 11:27 | ||||
| Reporter | UnitedMarsupials | ||||||||
| Assigned To | abma | ||||||||
| Priority | low | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 98.0 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004734: unzip.c exists in TRIPLICATE | ||||||||
| Description | Not only is the same code in unzip.c compiled three times while building spring -- and is included three times in the resulting binaries. The actual C-code -- of different versions -- is found three times in the tree as well: rts/lib/assimp/contrib/unzip/unzip.c rts/lib/minizip/unzip.c tools/pr-downloader/src/lib/minizip/unzip.c One instance -- shared by all pieces of the tree -- ought to be sufficient. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2015-04-09 09:38 |
wording imo is wrong: the minizip files are shipped TRIPLICATE. when the system provides minizip pr-downloader & spring at least, the system installed minizip is used. idk about assimp... imo complete removal won't happen, as most linux systems have no minizip package: for pr-downloader removal is difficult, because its a dedicated program/project so only candidate is the minizip in assimp. |
|
abma (administrator) 2015-04-09 10:16 |
Fix ad6577d46973db04de9002bc4fb30d1e8ed99260 committed to develop branch: fix 0004734: remove assimps unzip/minizip, thanks UnitedMarsupials!, repo: spring changeset id: 4802 |
|
abma (administrator) 2015-04-09 11:27 |
now: the minizip files are shipped twice + compiled only once when not found in system. removing the second minizip isn't possible because pr-downloader is a dedicated project |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-04-08 22:46 | UnitedMarsupials | New Issue | |
| 2015-04-09 09:38 | abma | Note Added: 0014315 | |
| 2015-04-09 10:16 | abma | Changeset attached | => spring develop ad6577d4 |
| 2015-04-09 10:16 | abma | Note Added: 0014316 | |
| 2015-04-09 10:16 | abma | Assigned To | => abma |
| 2015-04-09 10:16 | abma | Status | new => resolved |
| 2015-04-09 10:16 | abma | Resolution | open => fixed |
| 2015-04-09 11:27 | abma | Note Added: 0014319 | |
| Issue History |