View Issue Details

IDProjectCategoryView StatusLast Update
0004571Spring engineGeneralpublic2014-10-04 11:43
Reportersilentwings Assigned Toabma  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version97.0.1+git 
Summary0004571: "minimap geo" command has no effect
Description"/minimap geo px py sx sy" should set (engines) minimap pos and size, but it has no effect in 97.0.1-454. It does work in 97.0.1-445.
Steps To ReproduceTry to execute "/minimap geo 2 2 500 500".
TagsNo tags attached.
Checked infolog.txt for Errors

Relationships

has duplicate 0004570 closedabma [string "LuaUI/Widgets/gui_red_minimap.lua"]:323: gl.DrawMiniMap() can only be used if the minimap is in slave mode 

Activities

abma

2014-10-04 11:26

administrator   ~0013702

Last edited: 2014-10-04 11:26

reverting https://github.com/spring/spring/commit/bb410087240ec4a85cb7eb6d32c497d68e08c81d makes the widget gui_red_minimap.lua work for me.

silentwings

2014-10-04 11:32

reporter   ~0013703

Just as a note: gui_red_minimap is very badly coded and it wasn't my fault. BARs minimap widget is a better example (and afaics works with -454). I can't find any relevent docs so don't know how to judge what is at fault there.

gajop

2014-10-04 11:36

developer   ~0013704

When I rewrote the behavior I looked at http://springrts.com/wiki/UI_commands and asked if anyone had an issue with the change.
The change can imo be reverted but then the documentation needs to change too, and there needs to be a way to disable the minimap.

Issue History

Date Modified Username Field Change
2014-10-04 11:24 silentwings New Issue
2014-10-04 11:25 abma Relationship added has duplicate 0004570
2014-10-04 11:26 abma Note Added: 0013702
2014-10-04 11:26 abma Note Edited: 0013702
2014-10-04 11:32 silentwings Note Added: 0013703
2014-10-04 11:36 gajop Note Added: 0013704
2014-10-04 11:43 abma Changeset attached => spring develop ba11e442
2014-10-04 11:43 abma Assigned To => abma
2014-10-04 11:43 abma Status new => resolved
2014-10-04 11:43 abma Resolution open => fixed