View Issue Details

IDProjectCategoryView StatusLast Update
0004558Spring engineGeneralpublic2014-09-27 04:05
Reportersilentwings Assigned TojK  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version97.0.1+git 
Summary0004558: waterbounces don't generate their cegs
Descriptionworks in 97.0.1-126, doesn't work in 97.0.1-176 and later
Steps To Reproduceload current ba-test, give corsb and bomb the water. in 97.0.1-176 and later the bouncing bombs will only make a splash on their final bounce. in 97.0.1-126 they make splashes on all their bounces (as they should).
TagsNo tags attached.
Attached Files
watersplash_small_light.lua (Attachment missing)
corsb.lua (Attachment missing)
20140924_114535_Malibu Beach v1_97.0.1-425-g3d34d8b develop.sdf (Attachment missing)
Checked infolog.txt for Errors

Relationships

related to 0004562 closedjK waterbounce ceg problems with 97.0.1-436-gcfd2d71 

Activities

jK

2014-09-24 12:24

developer   ~0013664

Likely a typo/bug in BA's ceg and not in the engine.
It just worked before cause of a bug in the engine that made it work:
https://github.com/spring/spring/blob/develop/doc/changelog.txt#L43

silentwings

2014-09-24 12:39

reporter   ~0013666

The ceg that is used for the bounces is the same ceg as is used for the final explosion of the projectile. It appears in the second case but not in the first, so I don't think its a problem with the ceg.

Attached unitdef & ceg def.

(Note that this should be tested with both luaui and laurules disabled, since BA includes lua that adds additional splashes to most explosions of projectiles on water. Added a demo with this.)

jK

2014-09-24 18:20

developer   ~0013667

Last edited: 2014-09-24 18:20

that's no contra argument,
play/test all booleans (esp. water, ground & air condition flags)

silentwings

2014-09-24 20:33

reporter   ~0013668

After testing, it seems that cegs for waterbounces only appear if they have air=true. I assume this is a bug since one would not want watersplashes occuring in mid-air (and I believe it was not like this until recently); water=true is the natural condition. Wiki offered no help that I could find.

Issue History

Date Modified Username Field Change
2014-09-24 01:29 silentwings New Issue
2014-09-24 12:24 jK Note Added: 0013664
2014-09-24 12:24 jK Assigned To => jK
2014-09-24 12:24 jK Status new => feedback
2014-09-24 12:39 silentwings Note Added: 0013666
2014-09-24 12:39 silentwings Status feedback => assigned
2014-09-24 12:40 silentwings File Added: watersplash_small_light.lua
2014-09-24 12:40 silentwings File Added: corsb.lua
2014-09-24 12:41 silentwings File Added: 20140924_114535_Malibu Beach v1_97.0.1-425-g3d34d8b develop.sdf
2014-09-24 18:20 jK Note Added: 0013667
2014-09-24 18:20 jK Note Edited: 0013667
2014-09-24 20:33 silentwings Note Added: 0013668
2014-09-26 06:09 jK Changeset attached => spring develop 20e26a3d
2014-09-26 06:09 jK Status assigned => resolved
2014-09-26 06:09 jK Resolution open => fixed
2014-09-27 04:05 jK Relationship added related to 0004562