View Issue Details

IDProjectCategoryView StatusLast Update
0004541Spring engineGeneralpublic2014-09-13 08:40
ReporterGoogle_Frog Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version97.0.1+git 
Summary0004541: 97.0.1-372 Idle, flying planes do not circle correctly.
DescriptionWhen set to fly and left idle a plane should aim at its last move goal and make tight turns after it overshoots. In 97.0.1-372 planes overshoot their goal significantly before turning and occasionally wiggle quite far out from their goal.

This has lead to reports that planes do not follow orders because when a move order is given it is expected that the plane will circle around the destination. The new idle behaviour can lead them to go significantly off target so on small maps it looks like they are flying randomly.

This works in 91.0. I can bisect the issue later. The two screenshots show a comparison.
Steps To ReproduceSpawn 200 corhurc2 and set them to fly. Give a move order and watch the swarm.

Alternately you can spawn 1 corhurc2 and watch what it does.
TagsNo tags attached.
Attached Files
idlePlane97.0-372.png (Attachment missing)
idlePlane91.0.png (Attachment missing)
idlePlane97.0.1-43.png (Attachment missing)
idlePlane97.0.1-45.png (Attachment missing)
Checked infolog.txt for Errors

Activities

Google_Frog

2014-09-10 05:36

reporter   ~0013630

The good behaviour from 91.0 is removed somewhere between 94.1.1-1250-g9987143 and 94.1.1-1337-g53392e6. That is not where the current bad behaviour begins though.

Google_Frog

2014-09-10 05:43

reporter   ~0013631

96.0 has good behaviour on flat terrain but hilly areas cause the planes to overshoot when they interact with the hills.

Google_Frog

2014-09-10 15:50

reporter   ~0013632

I have bisected the issue to between 97.0-43 and 97.0-45. Both versions have the problem interacting with hills but 97.0-45 has a much larger turning circle.

Here is the commit:
https://github.com/spring/spring/commit/0361f97881dcf9a54d24564e7be10fffb0225e8e

This line looks like a typo which could cause this issue:
https://github.com/spring/spring/commit/0361f97881dcf9a54d24564e7be10fffb0225e8e#diff-31044a597f0ccd6a19a861f5d8e5f007L860

Google_Frog

2014-09-13 07:17

reporter   ~0013635

I've fixed these issues, PR created https://github.com/spring/spring/pull/129

Issue History

Date Modified Username Field Change
2014-09-10 05:12 Google_Frog New Issue
2014-09-10 05:12 Google_Frog File Added: idlePlane97.0-372.png
2014-09-10 05:36 Google_Frog Note Added: 0013630
2014-09-10 05:39 Google_Frog File Added: idlePlane91.0.png
2014-09-10 05:43 Google_Frog Note Added: 0013631
2014-09-10 15:41 Google_Frog File Added: idlePlane97.0.1-43.png
2014-09-10 15:48 Google_Frog File Added: idlePlane97.0.1-45.png
2014-09-10 15:50 Google_Frog Note Added: 0013632
2014-09-13 07:17 Google_Frog Note Added: 0013635
2014-09-13 08:40 Changeset attached => spring develop c95e3931
2014-09-13 08:40 Anonymous Status new => resolved
2014-09-13 08:40 Anonymous Resolution open => fixed