2019-08-25 00:58 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0004431Spring engineGeneralpublic2016-01-31 18:29
Reporterabma 
Assigned Togajop 
PrioritynormalSeverityfeatureReproducibilityalways
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0004431: allow ./spring --game rapid://ba:stable --map somemap
Descriptionto implement, detect tag, resolve ->
VFS.search('rapid/*/versions.gz')

parse versions.gz and search the tag:

if found, open/use the <hash>.sdp

-> done!?
Additional Informationneed to store the result of rapid://ba:stable in replay:

has to be a list of rapid-tag -> checksum, can't be a single value

so it uses the same archive when replaying a demo.
TagsNo tags attached.
Checked infolog.txt for lua Errors
Attached Files

-Relationships
+Relationships

-Notes

~0013266

abma (administrator)

Last edited: 2014-06-11 11:14

View 4 revisions

has to work with "internal" dependencies, too (modinfo.lua/mapinfo.lua)

this is needed for missions, else maintaining/keeping them up to date is A LOT of useless work / wastes a lot of bandwith, etcetc.

atm this idea only takes care of singleplayer, for hosting, lobby protocol / script.txt (?) has to be extended by some value(s)

~0013281

abma (administrator)

implemented a part of it:
https://github.com/spring/spring/commit/ff0d955f2b9ccfb072eb2ddd2f155304400982e7

~0014072

abma (administrator)

jk did the next part:

https://github.com/spring/spring/commit/6a4e5f1160e8045fd1e6cd0154e1e77aeed0a752

missing:

modinfo.lua dependencies left for full rapid support

~0014085

user744

Nice.
Can it be tested with http://springrts.com/dl/buildbot/default/develop/98.0.1-398-g80e6cfa/win32/spring_%7bdevelop%7d98.0.1-398-g80e6cfa_minimal-portable.7z ?

Works with Spring.Restart/Reload?

Do maps get downloaded too, when in startscript?
I only see "GetRapidName(modName);" but maybe miss something...not sure if that is within scope of this mantis.

https://github.com/spring/spring/blob/develop/doc/StartScriptFormat.txt -> update :) ?

~0014087

jK (developer)

| Do maps get downloaded too, when in startscript?
no downloading (neither for games nor maps)

~0014088

user744

"bandwith" and "full rapid support" made me think of downloading :/
So it is (for now?) 'only' to allow startscripts to do:
gametype=BA:stable
instead
of
gametype=BA_v4.7.sdz ?

~0014089

abma (administrator)

the downloading part very likely goes into the engine start menu.

~0015587

gajop (developer)

This works as far as I can see. Anything missing?

~0015588

abma (administrator)

"modinfo.lua dependencies left for full rapid support" ?!

~0015589

gajop (developer)

Added: https://github.com/spring/spring/commit/96df8cdca960dee9a25fd3bebdf02a99f19cd5b2

This seems to work for my tests with Scened-BA + Scened-ZK.
Examples:
- https://github.com/gajop/Scened-BA/blob/master/modinfo.lua
- https://github.com/gajop/Scened-ZK/blob/master/modinfo.lua

Does this make it complete then?

~0015591

hokomoko (developer)

Thanks!

~0015592

abma (administrator)

> Does this make it complete then?

yes! this was a long requested feature mostly for missions!
+Notes

-Issue History
Date Modified Username Field Change
2014-06-11 11:12 abma New Issue
2014-06-11 11:12 abma Note Added: 0013266
2014-06-11 11:13 abma Note Edited: 0013266 View Revisions
2014-06-11 11:13 abma Note Edited: 0013266 View Revisions
2014-06-11 11:14 abma Note Edited: 0013266 View Revisions
2014-06-14 04:57 abma Note Added: 0013281
2015-02-22 01:40 abma Note Added: 0014072
2015-02-26 03:31 user744 Note Added: 0014085
2015-02-26 17:21 jK Note Added: 0014087
2015-02-26 18:24 user744 Note Added: 0014088
2015-02-26 18:41 abma Note Added: 0014089
2016-01-30 22:43 gajop Note Added: 0015587
2016-01-30 22:57 abma Note Added: 0015588
2016-01-31 14:13 gajop Note Added: 0015589
2016-01-31 14:49 hokomoko Note Added: 0015591
2016-01-31 14:49 hokomoko Status new => resolved
2016-01-31 14:49 hokomoko Resolution open => fixed
2016-01-31 14:49 hokomoko Assigned To => gajop
2016-01-31 18:29 abma Note Added: 0015592
+Issue History