2025-07-21 09:41 CEST
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004239Spring engineGeneralpublic2014-01-01 22:552014-01-04 04:45
Reporterabma 
Assigned Toabma 
PrioritynormalSeverityfeatureReproducibilityalways
StatusresolvedResolutionfixed 
Product Version95.0.1+git 
Target VersionFixed in Version 
Summary0004239: osx compile broken
DescriptionIn file included from /buildbot/springrts/quick-macosx/build/rts/System/float3.h:9,
                 from /buildbot/springrts/quick-macosx/build/AI/Wrappers/Cpp/src/AIFloat3.h:8,
                 from /buildbot/springrts/quick-macosx/build/AI/Wrappers/Cpp/src/AIFloat3.cpp:3:
/buildbot/springrts/quick-macosx/build/rts/lib/streflop/streflop_cond.h: In function 'T std::hypot(T, T)':
/buildbot/springrts/quick-macosx/build/rts/lib/streflop/streflop_cond.h:86: error: ISO C++ forbids declaration of 't' with no type
In file included from /buildbot/springrts/quick-macosx/build/AI/Wrappers/Cpp/src/AIFloat3.h:8,
                 from /buildbot/springrts/quick-macosx/build/AI/Wrappers/Cpp/src/AIFloat3.cpp:3:
/buildbot/springrts/quick-macosx/build/rts/System/float3.h: At global scope:
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:37: error: ISO C++ forbids declaration of 'constexpr' with no type
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:37: error: expected ';' before 'float'
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:38: error: ISO C++ forbids declaration of 'constexpr' with no type
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:38: error: expected ';' before 'float'
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:338: error: 'CMP_EPS' was not declared in this scope
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:338: error: 'CMP_EPS' was not declared in this scope
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:338: error: 'CMP_EPS' was not declared in this scope
/buildbot/springrts/quick-macosx/build/rts/System/float3.h: In member function 'float float3::LengthNormalize()':
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:450: error: 'NORMALIZE_EPS' was not declared in this scope
/buildbot/springrts/quick-macosx/build/rts/System/float3.h: In member function 'float float3::LengthNormalize2D()':
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:458: error: 'NORMALIZE_EPS' was not declared in this scope
/buildbot/springrts/quick-macosx/build/rts/System/float3.h: In member function 'float3& float3::SafeNormalize()':
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:515: error: 'NORMALIZE_EPS' was not declared in this scope
/buildbot/springrts/quick-macosx/build/rts/System/float3.h: In member function 'float3& float3::SafeANormalize()':
/buildbot/springrts/quick-macosx/build/rts/System/float3.h:579: error: 'NORMALIZE_EPS' was not declared in this scope
make[2]: *** [AI/Wrappers/Cpp/CMakeFiles/Cpp-AIWrapper.dir/src/AIFloat3.cpp.o] Error 1
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
+Relationships

-Notes

~0012572

abma (administrator)

2014-01-01 22:56

 http://buildbot.springrts.com/builders/quick-macosx/builds/2693/steps/buildConfig/logs/stdio

~0012573

jK (developer)

2014-01-02 02:48

 seems its GCC needs updated (quick internet search showed it occurs with GCC <4.6)

~0012574

abma (administrator)

2014-01-02 05:30

 afaik gcc 4.7.1 runs on the osx buildslave, but not sure.

add a cmake check for gcc >=4.6 ?!

http://stackoverflow.com/questions/4058565/check-gcc-minor-in-cmake

~0012575

abma (administrator)

2014-01-02 05:31

 ugh, no:

http://buildbot.springrts.com/builders/quick-macosx/builds/2693/steps/build%20dir%20create/logs/stdio


not sure what daftalax did, 4.7.1 was installed some time ago.

~0012576

abma (administrator)

2014-01-02 05:32

Last edited: 2014-01-02 06:01

View 5 revisions

 4.6 is minimum? if so, the check should be added so it aborts at configure.

looks better:

http://stackoverflow.com/questions/14933172/how-can-i-add-a-minimum-compiler-version-requisite

requires >=cmake 2.8.10:

if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
  if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS "4.6")
    message(FATAL_ERROR "gcc >=4.6 required")
  endif()
endif()

~0012577

abma (administrator)

2014-01-02 05:59

 build setup broken -> no release blocker
+Notes

-Issue History
Date Modified Username Field Change
2014-01-01 22:55 abma New Issue
2014-01-01 22:56 abma Product Version => 95.0.1+git
2014-01-01 22:56 abma Note Added: 0012572
2014-01-02 02:48 jK Note Added: 0012573
2014-01-02 05:30 abma Note Added: 0012574
2014-01-02 05:31 abma Note Added: 0012575
2014-01-02 05:32 abma Note Added: 0012576
2014-01-02 05:32 abma Status new => feedback
2014-01-02 05:40 abma Note Edited: 0012576 View Revisions
2014-01-02 05:51 abma Note Edited: 0012576 View Revisions
2014-01-02 05:59 abma Note Added: 0012577
2014-01-02 05:59 abma Status feedback => new
2014-01-02 05:59 abma Status new => feedback
2014-01-02 05:59 abma Target Version 96.0 =>
2014-01-02 06:00 abma Severity major => feature
2014-01-02 06:01 abma Note Edited: 0012576 View Revisions
2014-01-02 06:01 abma Note Edited: 0012576 View Revisions
2014-01-04 04:37 abma Changeset attached => spring develop b76027d1
2014-01-04 04:37 abma Assigned To => abma
2014-01-04 04:37 abma Status feedback => resolved
2014-01-04 04:37 abma Resolution open => fixed
2014-01-04 04:41 abma Changeset attached => spring develop 0eab2294
2014-01-04 04:45 abma Changeset attached => spring develop e4d2e293
+Issue History