| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004166 | Spring engine | Lua | public | 2013-11-22 01:00 | 2013-11-23 22:38 | ||||
| Reporter | jamerlan | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 95.0 | ||||||||
| Target Version | 96.0 | Fixed in Version | |||||||
| Summary | 0004166: better logging of deprecated tags | ||||||||
| Description | Sorry guys. Could you please make these messages: https://github.com/spring/spring/blob/develop/rts/Lua/LuaUnitDefs.cpp#L600 more informative! I am getting: "Warning: [ReturnFalse] deprecated field!" and yes, I was trying to enable/disable widgets, I read forum with deprecated tags list but still I can't find widget that causes this messages and at least understand which deprecated tag is used. Is it possible to add info: Which deprecated tag was used? Looks like it's possible to do like that: LOG_L(L_ERROR, "[%s] ERROR_TYPE for key \"%s\" in UnitDefs __newindex", __FUNCTION__, name); is it possible to add a tag name like that? (I am not dreaming about file (widget) name - it would be TOO COOL :-D) | ||||||||
| Additional Information | pleeease | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
PepeAmpere (reporter) 2013-11-22 03:55 |
seems all devs has to come through this i suggest binary search to find given gadget/widget ;) i agree that current report style smells by jK, on the other hand there are only 3 folders where reason for this can be, number of files is not huge, so it takes few iterations to find it LuaRules - gamefile LuaUI - gamefile LuaUI - user folder (+ Rules and UI of map of course, but i consider it as gamefile archive) btw me experience with NOTA was, it were only .builder and .isCommander tags - and NOTA has some really ancient stuff in game archieve :) |
|
PepeAmpere (reporter) 2013-11-22 03:57 |
of course some unitDefs postdefs are other possible lua-gangsters and... other folders, if you dont keep your game file tidy up ;) |
|
cleanrock (reporter) 2013-11-22 17:03 |
I guess kloot tried to print the deprecated field in https://github.com/spring/spring/commit/4e58b8b0f Instead they just print the local function names. Just look at the commit message above to see what was deprecated. |
|
silentwings (reporter) 2013-11-22 18:24 |
Since you'll have to update them all you may as well just grep search for all the deprecated ones. |
|
jamerlan (reporter) 2013-11-22 19:47 |
this error message is not user friendly. Not friendly at all |
|
jamerlan (reporter) 2013-11-23 09:54 |
pull request was sent https://github.com/spring/spring/pull/86 |
|
abma (administrator) 2013-11-23 22:38 |
thanks! https://github.com/spring/spring/commit/ba53ff0f18effff66dcd9873b8fb86728ddae00a |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-11-22 01:00 | jamerlan | New Issue | |
| 2013-11-22 03:55 | PepeAmpere | Note Added: 0012193 | |
| 2013-11-22 03:57 | PepeAmpere | Note Added: 0012194 | |
| 2013-11-22 17:03 | cleanrock | Note Added: 0012195 | |
| 2013-11-22 18:24 | silentwings | Note Added: 0012196 | |
| 2013-11-22 19:47 | jamerlan | Note Added: 0012197 | |
| 2013-11-23 09:54 | jamerlan | Note Added: 0012198 | |
| 2013-11-23 22:38 | abma | Note Added: 0012199 | |
| 2013-11-23 22:38 | abma | Status | new => resolved |
| 2013-11-23 22:38 | abma | Resolution | open => fixed |
| 2013-11-23 22:38 | abma | Assigned To | => abma |
| 2013-11-23 22:38 | abma | Target Version | => 96.0 |
| Issue History |