| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004057 | Spring engine | General | public | 2013-10-14 18:06 | 2013-10-14 18:57 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 94.1.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004057: 94.1.1-1353 Double BeamLaser visualisation | ||||||||
| Description | BeamLasers with beamTTL=0 are drawn as a double beam when the emit point of the laser moves. The 'second beam' lags slightly behind the position of the emit point. It looks like the laser is being drawn for too long at each location. It is most noticeable for rapidly strafing gunships and I've made a test case to show this. | ||||||||
| Steps To Reproduce | Run Spring with ZK 11753 (the exact version is important), '/give armkam' and give the spawned unit an attack command. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2013-10-14 18:30 Last edited: 2013-10-14 18:31 |
also caused by 26dc09590b7e022f1105625e888a1b6b2e580c23 (I don't know why the params.ttl = std::max(1, weaponDef->beamLaserTTL) was added, but I assume to prevent a div0 somewhere) |
|
jK (developer) 2013-10-14 18:39 |
yup https://github.com/spring/spring/commit/26dc09590b7e022f1105625e888a1b6b2e58#diff-a0ebfab52fc32ef4f308ddce19dea7d5L95 |
|
Kloot (developer) 2013-10-14 18:43 Last edited: 2013-10-14 18:47 |
Shouldn't be necessary there, it's already wrapped inside a if (ttl <= 0) { deleteMe = true; } else { ... gCEG->Explosion(cegID, startpos + ((targetPos - startpos) / ttl) } block. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-10-14 18:06 | Google_Frog | New Issue | |
| 2013-10-14 18:06 | Google_Frog | File Added: bansheeDoubleLaser.jpg | |
| 2013-10-14 18:30 | Kloot | Note Added: 0011749 | |
| 2013-10-14 18:31 | Kloot | Note Edited: 0011749 | View Revisions |
| 2013-10-14 18:31 | Kloot | Note Edited: 0011749 | View Revisions |
| 2013-10-14 18:32 | Kloot | Assigned To | => jK |
| 2013-10-14 18:32 | Kloot | Status | new => assigned |
| 2013-10-14 18:39 | jK | Note Added: 0011751 | |
| 2013-10-14 18:43 | Kloot | Note Added: 0011752 | |
| 2013-10-14 18:47 | Kloot | Note Edited: 0011752 | View Revisions |
| 2013-10-14 18:57 | Kloot | Changeset attached | => spring develop 034bb0d0 |
| 2013-10-14 18:57 | Kloot | Assigned To | jK => Kloot |
| 2013-10-14 18:57 | Kloot | Status | assigned => resolved |
| 2013-10-14 18:57 | Kloot | Resolution | open => fixed |
| Issue History |