| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004011 | Spring engine | General | public | 2013-09-21 10:23 | 2013-09-21 17:52 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | reopened | ||||||
| Product Version | 94.1.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004011: GetTeamStartPosition cannot determine whether the start position was placed by the player | ||||||||
| Description | In 91.0 GetTeamStartPosition returns (-100,-100,-100) when the start position is not yet placed. Now it returns (0,0,0) (since this commit https://github.com/spring/spring/commit/e4dc43a3f1d622168a5634030842d6e609a5b30d). The position (0,0,0) could be a player placed start position and I think the whole position checking business is a bit of a hack (I only looked at this gadget since it was broken in 94.1+). So GetTeamStartPosition should return a 4th value, whether the player has placed the start position or not. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Google_Frog (reporter) 2013-09-21 10:28 Last edited: 2013-09-21 11:08 |
Ok, it turns out that (0,0,0) is not a valid start location. I still think that a position check is an abuse of the interface so the extra parameter would be nice. Priority should be lower too. |
|
Kloot (developer) 2013-09-21 12:50 |
GetTeamStartPosition cannot, AllowStartPosition can. |
|
Google_Frog (reporter) 2013-09-21 12:57 |
GetTeamStartPosition can be used in unsynced gadgets and widgets. AllowStartPosition is a callin for synced gadgets so to use GetTeamStartPosition in a nice way within widgets we would have to write a gadget which listens to AllowStartPosition and then puts the information in some sort of Team Rules Param. I think this is the sort of thing the engine should do. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-09-21 10:23 | Google_Frog | New Issue | |
| 2013-09-21 10:28 | Google_Frog | Note Added: 0011637 | |
| 2013-09-21 10:29 | Google_Frog | Note Edited: 0011637 | View Revisions |
| 2013-09-21 11:08 | Google_Frog | Note Edited: 0011637 | View Revisions |
| 2013-09-21 12:50 | Kloot | Note Added: 0011641 | |
| 2013-09-21 12:50 | Kloot | Status | new => closed |
| 2013-09-21 12:50 | Kloot | Assigned To | => Kloot |
| 2013-09-21 12:50 | Kloot | Resolution | open => no change required |
| 2013-09-21 12:57 | Google_Frog | Note Added: 0011642 | |
| 2013-09-21 12:57 | Google_Frog | Status | closed => feedback |
| 2013-09-21 12:57 | Google_Frog | Resolution | no change required => reopened |
| 2013-09-21 17:52 | Kloot | Changeset attached | => spring develop 06835d67 |
| 2013-09-21 17:52 | Kloot | Status | feedback => resolved |
| Issue History |