View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003872Spring engineGeneralpublic2013-06-25 10:062013-07-03 09:38
Reportermsafwan Assigned Tocleanrock  
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Product Version94.1.1+git 
Summary0003872: 94.1.1-659-g0c84527 & 94.1.1-662-g75f533b crash
DescriptionSpring 94.1.1-662-g75f533b & Spring 94.1.1-659-g0c84527 crashed at gamestart

The minimap was pure white, then the game exit to desktop and report access violation.

FYI:
Spring 94.1.1-645-g34c768b was OK for me.
Tagsminimap white
Checked infolog.txt for Errors

Activities

msafwan

2013-06-25 11:24

reporter   ~0010933

Last edited: 2013-07-01 04:23

 OPS I forgot about infolog. Here it is:
http://pastebin.com/Aiu8yyNR Spring 94.1.1-662-g75f533b
http://pastebin.com/YQvYBxLX Spring 94.1.1-659-g0c84527

Spring 94.1.1-675-g53efc3a also show white minimap at start and crash
infolog: http://pastebin.com/zMGSz6tg

Here is a screenshot http://s515.photobucket.com/user/xponen/media/P1070467low.jpg.html
ZK test 10637
Spring 94.1.1-675-g53efc3a

abma

2013-07-02 13:56

administrator   ~0010950

C:\\Users\\User\\Documents\\My Games\\Spring\\engine\\94.1.1-662-g75f533b\\spring.exe 0x0062783E rts/Rendering/GL/FBO.cpp:445
C:\\Users\\User\\Documents\\My Games\\Spring\\engine\\94.1.1-662-g75f533b\\spring.exe 0x00451108 /usr/lib/gcc/i686-mingw32/4.7.2/include/g++-v4/bits/stl_vector.h:88

&

C:\\Users\\User\\Documents\\My Games\\Spring\\engine\\94.1.1-659-g0c84527\\spring.exe 0x00627A3E rts/Rendering/GL/FBO.cpp:445
C:\\Users\\User\\Documents\\My Games\\Spring\\engine\\94.1.1-659-g0c84527\\spring.exe 0x00448F6A rts/Game/TraceRay.cpp:349

cleanrock

2013-07-02 14:38

reporter   ~0010951

rts/Rendering/GL/FBO.cpp:445 is
glRenderbufferStorageMultisampleEXT(GL_RENDERBUFFER_EXT, samples, format, width, height);

I did a bit of search and i wonder if GLEW_ARB_framebuffer_object is enough to try a multisampled render buffer, perhaps GLEW_EXT_framebuffer_multisample is needed.

cleanrock

2013-07-02 15:16

reporter   ~0010952

Last edited: 2013-07-02 15:19

 Forget my comment above, GLEW_ARB_framebuffer_object includes GLEW_EXT_framebuffer_multisample.

Btw, we use a hardcoded samples of 16, i think we should check GL_MAX_SAMPLES.

cleanrock

2013-07-02 15:25

reporter   ~0010953

Last edited: 2013-07-02 15:29

 Here is an interesting thread about multisampling on intel:
http://www.opengl.org/discussion_boards/showthread.php/181269-Yet-another-Intel-multisample-thread

Last post seem like a possible solution:
FWIW, I check (GL_ARB_multisample &&GL_EXT_framebuffer_multisample) for whether MSAA is supported and then cache the GL_MAX_SAMPLES value as the indicator of whether to use MSAA. ie if it returns 0, its going down the non-MSAA code path.

cleanrock

2013-07-02 16:44

reporter   ~0010954

I now see that we check GL_MAX_SAMPLES_EXT but i suspect its a bit too late, we already gone down the multisample branch.

cleanrock

2013-07-02 17:51

reporter   ~0010955

msafwan, please test this on your intel machine.

jk, this is probably something you want to cleanup if it solves the problem. If it dont solve the problem we revert it.

msafwan

2013-07-02 19:12

reporter   ~0010956

Spring 94.1.1-679-gb84cb15 don't crash for me anymore! thanks for the solution... looks like difficult investigation stuff!

Issue History

Date Modified Username Field Change
2013-06-25 10:06 msafwan New Issue
2013-06-25 10:07 msafwan Tag Attached: minimap white
2013-06-25 11:24 msafwan Note Added: 0010933
2013-07-01 02:08 msafwan Note Edited: 0010933
2013-07-01 04:22 msafwan Note Edited: 0010933
2013-07-01 04:23 msafwan Note Edited: 0010933
2013-07-02 13:56 abma Note Added: 0010950
2013-07-02 14:38 cleanrock Note Added: 0010951
2013-07-02 15:16 cleanrock Note Added: 0010952
2013-07-02 15:19 cleanrock Note Edited: 0010952
2013-07-02 15:25 cleanrock Note Added: 0010953
2013-07-02 15:29 cleanrock Note Edited: 0010953
2013-07-02 16:44 cleanrock Note Added: 0010954
2013-07-02 17:48 cleanrock Changeset attached => spring develop b84cb15e
2013-07-02 17:48 cleanrock Assigned To => cleanrock
2013-07-02 17:48 cleanrock Status new => resolved
2013-07-02 17:48 cleanrock Resolution open => fixed
2013-07-02 17:51 cleanrock Note Added: 0010955
2013-07-02 17:51 cleanrock Status resolved => feedback
2013-07-02 17:51 cleanrock Resolution fixed => reopened
2013-07-02 19:12 msafwan Note Added: 0010956
2013-07-02 19:12 msafwan Status feedback => assigned
2013-07-03 09:38 cleanrock Status assigned => resolved
2013-07-03 09:38 cleanrock Resolution reopened => fixed