View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003814 | Spring engine | General | public | 2013-05-26 00:18 | 2013-06-02 15:34 |
| Reporter | jamerlan | Assigned To | cleanrock | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 94.1 | ||||
| Target Version | 95.0 | ||||
| Summary | 0003814: If you share underwater unit to ally - it becomes invisible for both (ally and you) | ||||
| Description | If you share underwater unit (any kind. For example - landed seaplanes) - you can't see it anymore but your ally can't see it too. | ||||
| Steps To Reproduce | 1. Share underwater units to ally 2. These units becomes invisible | ||||
| Additional Information | take a look at attached demo. Infolog.txt : http://pastebin.com/7VhwPmJA | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
[02:15:45] <[Fx]Bluestone> decay is right with his bug btw, you can really make units vanish (when sharing underwater) :p |
|
|
Shit, I just realized that SPECTATORS can see shared underwater units... so you need to reproduce it manually while playing. Just add AI as ally and share him underwater units |
|
|
I was unable to reproduce this with BA 7.76 with both 94.1 and 94.1.1-592-gb53a627 develop (OMP). I shared a submarine and a seaplane to ally AI and i could still see them. |
|
|
try to share t1 mexes. We were testing on them |
|
|
also, maybe you was close to them with your own units. Just share mexes (for example) not near of your units |
|
|
I can reproduce this problem with mexes on 94.1 and develop 8f53c96a. I will probably try a bisect but i think jk and kloot should look at this, one of em should have an idea of when they broke it :). |
|
|
bisect attempt failed, bisecting spring on arch seem to be a nightmare, every version git bisect tried crashed for me. |
|
|
maybe this bugfix affected visibility behaviour? http://springrts.com/mantis/view.php?id=3544 https://github.com/spring/spring/commit/13b887e5f822c5c2c170de8c4a6819c339d3251a |
|
|
or maybe this: http://springrts.com/mantis/view.php?id=3481 https://github.com/spring/spring/commit/ee13fb168cc8ebd4943588f891ddd0e791efa762 |
|
|
I attached a patch (ChangeTeam.patch) that fix this particular problem but it may also break 3544. I suspect it is these lines in LosHandler::InLos(const CUnit* unit, int allyTeam) that cause the problem if (unit->IsUnderWater() && requireSonarUnderWater) return (radarhandler->InRadar(unit, allyTeam)); but i think this problem should be corrected in by CUnit::ChangeTeam. |
|
|
Kloot, i dont dare to commit this, can u resolve this ? |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-05-26 00:18 | jamerlan | New Issue | |
| 2013-05-26 00:18 | jamerlan | File Added: 20130526_021002_Schizo_Shores_v4_94.sdf | |
| 2013-05-26 00:20 | jamerlan | Note Added: 0010766 | |
| 2013-05-26 01:04 | jamerlan | Note Added: 0010767 | |
| 2013-05-26 15:37 | abma | Target Version | => 95.0 |
| 2013-05-30 16:28 | cleanrock | Note Added: 0010790 | |
| 2013-05-30 17:34 | jamerlan | Note Added: 0010791 | |
| 2013-05-30 17:35 | jamerlan | Note Added: 0010792 | |
| 2013-05-31 15:44 | cleanrock | Note Added: 0010794 | |
| 2013-05-31 16:29 | cleanrock | Note Added: 0010795 | |
| 2013-05-31 17:03 | jamerlan | Note Added: 0010796 | |
| 2013-05-31 17:06 | jamerlan | Note Added: 0010797 | |
| 2013-06-01 11:26 | cleanrock | Note Added: 0010799 | |
| 2013-06-01 11:27 | cleanrock | File Added: ChangeTeam.patch | |
| 2013-06-01 19:04 | cleanrock | Note Added: 0010803 | |
| 2013-06-02 09:15 | cleanrock | Assigned To | => cleanrock |
| 2013-06-02 09:15 | cleanrock | Status | new => assigned |
| 2013-06-02 10:46 | cleanrock | Changeset attached | => spring develop fd26f177 |
| 2013-06-02 10:46 | cleanrock | Status | assigned => resolved |
| 2013-06-02 10:46 | cleanrock | Resolution | open => fixed |
| 2013-06-02 15:34 | abma | Relationship added | related to 0003544 |
