| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003789 | Spring engine | General | public | 2013-05-11 15:25 | 2013-05-11 16:28 | ||||
| Reporter | burp | ||||||||
| Assigned To | abma | ||||||||
| Priority | high | Severity | crash | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | 95.0 | |||||||
| Summary | 0003789: bug in sound code | ||||||||
| Description | Helping out overtired developers :) It's interesting that this made no problems for me until recently… (still in 94) diff -rN -u old-spring_91.0/rts/System/Sound/EFX.cpp new-spring_91.0/rts/System/Sound/EFX.cpp --- old-spring_91.0/rts/System/Sound/EFX.cpp 2013-05-11 15:14:57.271906977 +0200 +++ new-spring_91.0/rts/System/Sound/EFX.cpp 2013-05-11 15:14:57.271906977 +0200 @@ -83,7 +83,7 @@ ALuint alFx; alGenEffects(1, &alFx); if (alGetError() == AL_NO_ERROR) { - for(size_t i = 0; i < sizeof(effects); i++) { + for(size_t i = 0; i < sizeof(effects)/sizeof(ALuint); i++) { const ALuint fx = effects[i]; alEffecti(alFx, AL_EFFECT_TYPE, fx); effectsSupported[fx] = (alGetError() == AL_NO_ERROR); @@ -103,7 +103,7 @@ ALuint alFilter; alGenFilters(1, &alFilter); if (alGetError() == AL_NO_ERROR) { - for(size_t i = 0; i < sizeof(filters); i++) { + for(size_t i = 0; i < sizeof(filters)/sizeof(ALuint); i++) { const ALuint filter = filters[i]; alFilteri(alFilter, AL_FILTER_TYPE, filter); filtersSupported[filter] = (alGetError() == AL_NO_ERROR); | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2013-05-11 16:28 |
that was already fixed a month ago: https://github.com/spring/spring/commit/b008ada6a02c464ebdb7a724f8bc48517c41a90a next time please check current develop branch please :) |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-05-11 15:25 | burp | New Issue | |
| 2013-05-11 16:28 | abma | Note Added: 0010687 | |
| 2013-05-11 16:28 | abma | Status | new => resolved |
| 2013-05-11 16:28 | abma | Fixed in Version | => 95.0 |
| 2013-05-11 16:28 | abma | Resolution | open => fixed |
| 2013-05-11 16:28 | abma | Assigned To | => abma |
| Issue History |