View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003659 | Spring engine | General | public | 2013-03-29 11:16 | 2013-03-31 17:17 |
| Reporter | cleanrock | Assigned To | Kloot | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | won't fix | ||
| Product Version | 94.1 | ||||
| Summary | 0003659: tdf_grammar throws when section name contain special chars | ||||
| Description | I got a SETSCRIPTTAGS message from a Spads hosts with player info (file with message attached) where some names contain brackets, flobby includes this info in start script (file attached) which spring will barf on with the following message: Error: Spring: Incorrect/Missing content: Parse error 'brace or further name value pairs expected' in buffer at line 85 column 5 near [[ACE]KRAPOO] I think the parser in spring should be able to handle this, i.e. match the ending bracket. | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
As specified in the startscript format file ( https://github.com/spring/spring/blob/master/doc/StartScriptFormat.txt ), non-host lobby clients only have to write the information to connect to the host in the startscript. In your startscript example, all the modoptions will be ignored by Spring, which will use the modoptions of the host startscript instead. See this forum post for more information: http://springrts.com/phpbb/viewtopic.php?p=538545#p538545 |
|
|
We should update http://springrts.com/dl/LobbyProtocol/ProtocolDescription.html#SETSCRIPTTAGS:server This part is no longer true: A client lobby program must cache and process these tags and apply them accordingly when creating the "script.txt" file. |
|
|
Agreed, this doc should have been updated when client startscript usage has been changed a few years ago. Here is a patch proposal: http://planetspads.free.fr/spads/tmp/ProtocolDescription.xml.patch |
|
|
bibim, that patch link do not work for me in firefox, can you attach patch ? |
|
|
use right click, save as |
|
|
forwarded the protocol change: https://github.com/spring/LobbyProtocol/issues/13 |
|
|
The tdf grammar is not strictly defined but should be kept as simple as possible. Allowing reserved tokens in section names is not a good idea. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-03-29 11:16 | cleanrock | New Issue | |
| 2013-03-29 11:16 | cleanrock | File Added: setscripttags_message.txt | |
| 2013-03-29 11:17 | cleanrock | File Added: flobby_script.txt | |
| 2013-03-29 14:10 | bibim_ | Note Added: 0010311 | |
| 2013-03-29 16:27 | cleanrock | Note Added: 0010313 | |
| 2013-03-29 17:28 | bibim_ | Note Added: 0010314 | |
| 2013-03-30 07:16 | cleanrock | Note Added: 0010320 | |
| 2013-03-30 09:21 | bibim_ | Note Added: 0010321 | |
| 2013-03-30 11:00 | abma | Note Added: 0010322 | |
| 2013-03-31 17:17 | Kloot | Note Added: 0010337 | |
| 2013-03-31 17:17 | Kloot | Status | new => closed |
| 2013-03-31 17:17 | Kloot | Assigned To | => Kloot |
| 2013-03-31 17:17 | Kloot | Resolution | open => won't fix |
