View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003637Spring engineGeneralpublic2013-03-25 23:122013-04-02 13:25
Reporterabma Assigned ToKloot  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version94.1 
Summary0003637: auto delete cache/paths when stale path-cache is detected or throw a bigger warning?!
Descriptionmany players desynced after the switch to 94.0, deleting the cache/path folder seems to fix the desyncs.

my guess is:

the pathfinder cache version of 93.x and 94.x is the same but because of the pathfinder fixes, the content should be different.
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

Kloot

2013-03-25 23:19

developer   ~0010247

I forgot to bump PATHESTIMATOR_VERSION.

abma

2013-03-25 23:20

administrator   ~0010248

Last edited: 2013-03-25 23:35

 then maybe for the future: automaticly delete the cache if "stale path estamiator cache" is detected?

or set it automaticly to the version of spring?

abma

2013-03-25 23:38

administrator   ~0010249

Last edited: 2013-03-25 23:39

 is a 94.1 possible with changed PATHESTIMATOR_VERSION?

Kloot

2013-03-25 23:46

developer   ~0010250

Technically yes, it would still sync with 94.0. But by the time that gets released everyone will have deleted their cache folders anyway...

abma

2013-03-25 23:57

administrator   ~0010251

yeah, but its still possible that people switch engine version, so imo we should pump it at all and make a 94.1 release

abma

2013-03-26 00:07

administrator   ~0010252

grepped for PATHESTIMATOR_VERSION
https://github.com/spring/spring/blob/develop/rts/Sim/Path/Default/PathEstimator.cpp#L970

this makes me think the hash changes when PATHESTIMATOR_VERSION is bumped. this would mean the "stale path estamiator cache" is still printed but theoretically it syncs, right?

Kloot

2013-03-26 00:19

developer   ~0010253

yup, because 94.0 and 94.1 would calculate cache data identically

abma

2013-03-26 00:23

administrator   ~0010254

ok, 94.1 is on the way... (to annoying to explain everyone how to delete the cache...)

abma

2013-03-26 01:40

administrator   ~0010258

make PATHESTIMATOR_VERSION depend on the major version of spring?

Kloot

2013-03-26 01:55

developer   ~0010259

thinking about it, manually incrementing is obviously too fragile

Issue History

Date Modified Username Field Change
2013-03-25 23:12 abma New Issue
2013-03-25 23:19 Kloot Note Added: 0010247
2013-03-25 23:20 abma Note Added: 0010248
2013-03-25 23:33 abma Severity crash => feature
2013-03-25 23:33 abma Summary desync because of path cache => auto delete cache/paths when stale path-cache is detected or throw a bigger warning?!
2013-03-25 23:33 abma Additional Information Updated
2013-03-25 23:34 abma Note Edited: 0010248
2013-03-25 23:35 abma Note Edited: 0010248
2013-03-25 23:38 abma Note Added: 0010249
2013-03-25 23:39 abma Note Edited: 0010249
2013-03-25 23:46 Kloot Note Added: 0010250
2013-03-25 23:57 abma Note Added: 0010251
2013-03-26 00:07 abma Note Added: 0010252
2013-03-26 00:19 Kloot Note Added: 0010253
2013-03-26 00:23 abma Note Added: 0010254
2013-03-26 01:40 abma Note Added: 0010258
2013-03-26 01:55 Kloot Note Added: 0010259
2013-04-02 13:25 Kloot Changeset attached => spring develop 260d5058
2013-04-02 13:25 Kloot Assigned To => Kloot
2013-04-02 13:25 Kloot Status new => resolved
2013-04-02 13:25 Kloot Resolution open => fixed