View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003540 | Spring engine | General | public | 2013-03-09 03:31 | 2013-03-11 23:02 |
| Reporter | msafwan | Assigned To | Kloot | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 93.0 | ||||
| Summary | 0003540: Camera smooth function no longer working. | ||||
| Description | To demonstrate this: add unit into group number, press group number, and you will see that camera transition no longer available! Now camera instantly teleport and move in stepwise fashion. IMO this is related to this fix: http://springrts.com/mantis/view.php?id=3452 Can't someone figure out how the original stutter came from and not fix it with something else? | ||||
| Tags | camera transition | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
I think Spring 91 camera is OK, it don't have the stutter. But IMO i prefer stutter than no camera transition |
|
|
msafwan, selecting group twice in 91 do not trigger a camera transition as far as i can see. I am a bit unsure of this but here goes: If we keep UpdateCam(); in start of CCameraHandler::CameraTransition we need call CameraTransition before setting camera pos. I attached a patch which fixes transitions for F3 and transition to com at start. There are a few other places we call CameraTransition after setting pos which may need fixing: CCameraHandler::ToggleOverviewCamera() second call to CameraTransition in COverheadController::MouseWheelMove(float move) LuaUnsyncedCtrl::SetCameraState(lua_State* L) SmoothController::MouseWheelMove(float move) |
|
|
owwhh... kk sorry. What I meant was "Spring.SetCameraTarget(x,y,z,smooth)" no longer has smooth feature. I forgot I was using it for group recall. -_- I really scared if I cause some unnecessary code change. I really don't understand what's going on :( Cleanrock, do you know when do camera focus on commander at start? I would like to override it with Spring.SetCameraTarget() with smooth in Spring 91. |
|
|
msafwan, start com transition in 91 is smooth, what do u want to change ? |
|
|
cleanrock, I am using Freestyle camera and Spring.SetCameraTarget() will only show you correct target if you view from South like TA camera. So in ZK I put this override: https://code.google.com/p/zero-k/source/browse/trunk/mods/zk/LuaUI/cache.lua#99 so whenever I rotate the camera in any direction, the Spring.SetCameraTarget() can still point toward the right position. I would like to override for com start, BUT if someone can integrate it into Spring then will be cool! :> but the formula fail when you view toward sky, so its not perfect. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-03-09 03:31 | msafwan | New Issue | |
| 2013-03-09 03:32 | msafwan | Tag Attached: original camera transition | |
| 2013-03-09 03:33 | msafwan | Tag Detached: original camera transition | |
| 2013-03-09 03:33 | msafwan | Tag Attached: camera transition | |
| 2013-03-09 03:59 | msafwan | Note Added: 0010017 | |
| 2013-03-09 09:34 | cleanrock | Note Added: 0010018 | |
| 2013-03-09 09:37 | cleanrock | File Added: cam_transition.patch | |
| 2013-03-09 15:43 | msafwan | Note Added: 0010019 | |
| 2013-03-09 15:45 | msafwan | Note Edited: 0010019 | |
| 2013-03-09 16:44 | zerver | Assigned To | => zerver |
| 2013-03-09 16:44 | zerver | Status | new => assigned |
| 2013-03-10 08:04 | cleanrock | Note Added: 0010021 | |
| 2013-03-10 14:28 | msafwan | Note Added: 0010025 | |
| 2013-03-10 14:30 | msafwan | Note Edited: 0010025 | |
| 2013-03-10 14:31 | msafwan | Note Edited: 0010025 | |
| 2013-03-10 14:33 | msafwan | Note Edited: 0010025 | |
| 2013-03-10 23:03 | zerver | Changeset attached | => spring develop a70ef844 |
| 2013-03-10 23:03 | zerver | Status | assigned => resolved |
| 2013-03-10 23:03 | zerver | Resolution | open => fixed |
| 2013-03-11 23:02 | Kloot | Changeset attached | => spring release 728c1a13 |
| 2013-03-11 23:02 | Kloot | Assigned To | zerver => Kloot |
