View Issue Details

IDProjectCategoryView StatusLast Update
0000349Spring engineGeneralpublic2007-01-02 11:19
ReporterKloot Assigned Totvo  
PrioritynormalSeveritytweakReproducibilityN/A
Status resolvedResolutionfixed 
Summary0000349: patch to enable seaplanes to land *IN* water
DescriptionThis is sort of a corollary to patch 0000343, and introduces a new FBI tag 'canSubmerge'. The exact behavior of planes is now as follows when told to land above water:

1) If a plane only has the 'floater' tag set to 1, it will land on the ocean surface.
2) If a plane only has the 'canSubmerge' tag set to 1, it will land on the ocean floor.
3) If a plane has both tags set to 1, it will obey rule #2.

Another way to achieve this without adding a new tag would be by eg. requiring that maxWaterDepth > 0, but mod authors might want to use that tag for other purposes.
TagsNo tags attached.
Attached Files
seaplanesV2.patch (Attachment missing)
seaplanesV3.patch (Attachment missing)
Checked infolog.txt for Errors

Activities

Kloot

2006-12-28 00:17

developer   ~0000488

Whoops, 'rule 0000002' obviously should read 'rule 2'.

tvo

2006-12-31 15:31

reporter   ~0000497

committed, after minor modification

tvo

2006-12-31 16:23

reporter   ~0000499

hmm I just noticed you only changed CTAAirMoveType, but there also is CAirMoveType. It seems they're used for different types of aircraft, so maybe you could look into fixing & testing CAirMoveType too?

Kloot

2007-01-01 13:28

developer   ~0000502

will do as soon as the world stops spinning again :]

Kloot

2007-01-01 21:21

developer   ~0000504

Patch for CAirMoveType (seaplanesV3) submitted.

For reference, aircraft that satisfy the expression...

    (type == "Builder" || ud->hoverAttack || ud->transportCapacity)

...use CTAAirMoveType, all others use CAirMoveType.

tvo

2007-01-02 11:18

reporter   ~0000507

committed, thank you

Issue History

Date Modified Username Field Change
2006-12-28 00:12 Kloot New Issue
2006-12-28 00:12 Kloot File Added: seaplanesV2.patch
2006-12-28 00:17 Kloot Note Added: 0000488
2006-12-31 15:31 tvo Status new => resolved
2006-12-31 15:31 tvo Resolution open => fixed
2006-12-31 15:31 tvo Assigned To => tvo
2006-12-31 15:31 tvo Note Added: 0000497
2006-12-31 16:23 tvo Status resolved => feedback
2006-12-31 16:23 tvo Resolution fixed => reopened
2006-12-31 16:23 tvo Note Added: 0000499
2007-01-01 13:28 Kloot Note Added: 0000502
2007-01-01 21:21 Kloot Note Added: 0000504
2007-01-01 21:21 Kloot File Added: seaplanesV3.patch
2007-01-02 11:18 tvo Note Added: 0000507
2007-01-02 11:19 tvo Status feedback => resolved
2007-01-02 11:19 tvo Resolution reopened => fixed