2019-12-10 23:39 CET

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0000348Spring engineGeneralpublic2006-12-27 20:37
ReporterKloot 
Assigned Totvo 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0000348: patch to prevent transports from picking up cloaked enemy units
DescriptionOne-line change to Sim/Units/CommandAI/TransportCAI.cpp preventing cloaked enemy units from getting picked up anyway by player transports via area load.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files
  • patch file icon transport.patch (466 bytes) 2006-12-27 14:22 -
    Index: TransportCAI.cpp
    ===================================================================
    --- TransportCAI.cpp	(revision 2968)
    +++ TransportCAI.cpp	(working copy)
    @@ -244,7 +244,7 @@
     {
     	CTransportUnit* transport=(CTransportUnit*)owner;
     
    -	if(unit->mass>=100000 || unit->beingBuilt)
    +	if(unit->mass>=100000 || unit->beingBuilt || unit->isCloaked)
     		return false;
     	if(unit->unitDef->canhover || unit->unitDef->floater || unit->unitDef->canfly)
     		return false;
    
    patch file icon transport.patch (466 bytes) 2006-12-27 14:22 +

-Relationships
+Relationships

-Notes

~0000485

trepan (reporter)

This also prevents transports from picking up
cloaked friendly units. Might it be better to
only disallow enemy units? Should enemy units
within radar be allowed? (they'll be decloaked
by the time the transport gets there if they
have a decloak range).

~0000486

tvo (reporter)

Disallowing only enemies would be better. Enemies within radar should be allowed. (Consistent with e.g. attack which works on radar dots too.)

Committed the initial patch. A new one which also does the above would be appreciated :-)

~0000487

tvo (reporter)

Ok, fixed it to disallow only enemies. Didn't do the radar thing but that's so minor I skipped it.

Also fixed transports loading units outside LOS with area load.
+Notes

-Issue History
Date Modified Username Field Change
2006-12-27 14:22 Kloot New Issue
2006-12-27 14:22 Kloot File Added: transport.patch
2006-12-27 15:20 trepan Note Added: 0000485
2006-12-27 19:18 tvo Note Added: 0000486
2006-12-27 20:37 tvo Status new => resolved
2006-12-27 20:37 tvo Resolution open => fixed
2006-12-27 20:37 tvo Assigned To => tvo
2006-12-27 20:37 tvo Note Added: 0000487
+Issue History